Add useKeyPress hooks and shortcut in ImportModal
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AykutSarac
requested changes
Jun 17, 2022
src/containers/ImportModal/index.tsx
Outdated
| @@ -7,6 +7,7 @@ import { ConfigActionType } from "src/reducer/reducer"; | |||
| import { Modal, ModalProps } from "src/components/Modal"; | |||
| import { Button } from "src/components/Button"; | |||
| import { AiOutlineUpload } from "react-icons/ai"; | |||
| import useKeyPress from "../../hooks/useKeyPress"; | |||
There was a problem hiding this comment.
change import to absolute path
src/containers/ImportModal/index.tsx
Outdated
| const handleEspacePress = useKeyPress("Escape"); | ||
| const handleEnterKeyPress = useKeyPress("Enter"); | ||
| React.useEffect(() => { | ||
| if (handleEspacePress) { |
There was a problem hiding this comment.
reduce condition to single line if (...) doSomething()
AykutSarac
requested changes
Jun 18, 2022
src/hooks/useKeyPress.tsx
Outdated
| const [keyPressed, setKeyPressed] = React.useState(false); | ||
|
|
||
| function downHandler({ key }) { | ||
| if (key === targetKey) { |
There was a problem hiding this comment.
reduce conditions to one line
src/hooks/useKeyPress.tsx
Outdated
| } | ||
| } | ||
| const upHandler = ({ key }) => { | ||
| if (key === targetKey) { |
There was a problem hiding this comment.
reduce conditions to one line
|
Please add key shortcuts to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.