child property as second parameter #265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Media widget currently looks like this
With this PR its possible to save some indents, and less
child
andchildren
keywordtwo issues that arise with this
this could be mitigated with custom formatters
this can be solved somewhat redundantly, but honestly I don't think we need to, we can just assume there will always be an object passed, only time I can imagine this happen is with
Box
, which should instead also take an array of widgets as its first parameter, just like howLabel
can take a string,but thats going to be another commitedit: both are valid
3. Widgets not fully subclassed, but only with Widget.subclass utility, will be typed as if they can take a child3. Widgets not fully subclassed can't take a child as second parameter for simplicity