-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get IPV4/6 from Network service #327
Conversation
they should be defined as gobject properties and they should connect to the ip config object to listen for changes |
I am not sure if this is what you meant, sorry very new to Typescript, i am open for suggestions. |
is it possible for the ip4 and ip6 config objects to change on the device? should be handled if they can |
Yes the ips can change on a device, i know its quite rare. For me its a huge help |
Came here to request this feature or potentially contribute, glad to see this already being pursued 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a Device subclass, to avoid code repetition
Device extends Service
Wifi extends Device
Wired extends Device
I will see what i can come up with |
This PR simply add IP info that can be collected from the Network service both from WiFi or Wired
How to Implement to your code