Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support androidx and fix iOS crash #23

Closed
wants to merge 2 commits into from

Conversation

HarelM
Copy link
Contributor

@HarelM HarelM commented Mar 18, 2022

Fixes #21 - support androidx.
After merging this I suggest to release a version with an incremented major number i.e 4.x since this is a breaking change.

@HarelM HarelM changed the title Support androidx Support androidx and fix iOS crash Mar 20, 2022
@HarelM
Copy link
Contributor Author

HarelM commented Mar 20, 2022

I've also fixed the iOS crash according to #18 as part of this PR.

@dpogue
Copy link
Member

dpogue commented Mar 27, 2022

Thanks for the pull request and for following up with me about it.

My plan is to do this in a few steps:

  1. Merge only the iOS 15 fix to master and release v3.0.2
    This will fix the iOS issue while maintaining compatibility with existing apps.

  2. Cherry pick the iOS 15 fix to v2.x and release v2.0.2
    As requested by some of the folks in Fix issue with invalid callback scheme #19.

  3. Merge the AndroidX changes and release a new major version v4.0.0
    Moving to AndroidX is a breaking change, and requires bumping the minimum Cordova Android version to v9.0.0.

Can you check if the CustomTabs stuff in plugin.xml needs to change for AndroidX?

<preference name="ANDROID_SUPPORT_CUSTOM_TABS_VERSION" default="28.+" />
<framework src="com.android.support:customtabs:$ANDROID_SUPPORT_CUSTOM_TABS_VERSION" />

@HarelM
Copy link
Contributor Author

HarelM commented Mar 28, 2022

I couldn't find any documentation on that unfortunately...

@dpogue dpogue mentioned this pull request Mar 29, 2022
@dpogue
Copy link
Member

dpogue commented Mar 31, 2022

These have been split up across the various tags/versions as described above and merged, so I'm going to mark this as closed. Thanks for pushing this along.

@dpogue dpogue closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support for androidx
2 participants