Invert budget groups order at investment form #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to present heading "Toda la ciudad" before every other heading so we just order Budget grups descending so "Toda la ciudad" will be firt and "Districts" second
voodoorai2000
approved these changes
Jan 22, 2018
* Update budget heading order scenario to check new option name rules * Update other scenarios that were expecting old heading naming convention
bertocq
force-pushed
the
invert_budget_groups_order
branch
from
701eaba to
3ee5f09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
"Toda la ciudad: Toda la ciudad" should be first option at heading selection on Investment form
How
Just order Budget Groups by name but descending, so always "Toda la ciudad" will be above "Distritos", and that will make the heading "Toda la ciudad" always be on top of any other heading.
As a bonus we're removing the Budget::Group name from the option text when it only has one heading.
Screenshots
Test
Increased investment feature spec adding an scenario for this particular change on madrid's codebase and avoid mixing it with other scenarios that should be equal to consul's ones.
Deployment
As usual
Warnings
None