Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upstream] Split rubocop rules #1696

Merged
merged 2 commits into from
Oct 29, 2018
Merged

[Upstream] Split rubocop rules #1696

merged 2 commits into from
Oct 29, 2018

Conversation

javierm
Copy link

@javierm javierm commented Oct 29, 2018

References

  • Upstream pull request consul#2987

Objectives

  • Use the same rubocop files in Madrid and CONSUL so they're easier to maintain

@javierm
Remove rubocop_todo file
d1a5d60 
No developers are maintaining it anymore.
@javierm
Split rubocop configuration
40281ff 
This way we can ask contributors to follow some basic guidelines like
removing trailing whitespaces while not overwhelming them with all our
rules.
@javierm javierm merged commit 9889098 into master Oct 29, 2018
@javierm javierm deleted the upstream-houndci_basic branch October 29, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decabeza decabeza decabeza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierm @decabeza