feat: support value in the tolerations config #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kleber Rocha <klinux@gmail.com>
|
I will check th pr tomorrow |
|
Do you need this one in 2.24.1? @klinux |
alfespa17
pushed a commit
that referenced
this pull request
Dec 13, 2024
Signed-off-by: Kleber Rocha <klinux@gmail.com>
alfespa17
added a commit
that referenced
this pull request
Dec 13, 2024
stanleyz
pushed a commit
to stanleyz/terrakube
that referenced
this pull request
Mar 11, 2025
Signed-off-by: Kleber Rocha <klinux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR support value in the toleration config.
In GCP we can't create tolerations using only key, and in some configurations, we need to support value in the toleration.
Now, terrakube supports only: key:operator:effect, the PR insert the possibilily to set: key=value:operator:effect.
Thank you