Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a lock function to burgs #612

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Added a lock function to burgs #612

merged 2 commits into from
Mar 29, 2021

Conversation

Legogizmo
Copy link
Contributor

This adds a burg lock feature which can be accessed from the "burgs overview" and "burg editor" windows seen below.
Walkthrough1
Walkthrough3

The primary use is to keep selected burgs when using the regenerate Burgs feature.
Other uses include:

  • Locked burgs will not be renamed by the "regenerate burg names" in the burgs overview window
  • Will not be deleted when using the remove all burgs option in the burgs overview window
  • Will not have their population changed by regenerate population tool

Locked burgs can still be modified in the following ways:

  • Will still be deleted if the group they are assigned to is removed
  • Groups will still be re-assigned by regenerating burgs or states
  • Capital status may still be changed by regenerating states
  • Culture can still be changed
  • The seed for Medieval Fantasy City Generator will be changed unless a custom one is set
  • Emblems will sometimes change or stay the same depending on the order in which you change the culture and state, Regenerating Emblems will always change the emblem.

@Azgaar
Copy link
Owner

Azgaar commented Mar 26, 2021

Thanks, looks good, I will try to review it today.

@Azgaar
Copy link
Owner

Azgaar commented Mar 27, 2021

Hello. It looks really good! Just a few minor points I would like to amend:

  • Burg name should stay as is when Cultures names are regenerated (via Cultures Editor)
  • Lock icon should have a pointer cursor (in Burg overview)
  • Lock tooltip is not very clear on what lock is doing. The tooltip can be more detailed (in both Burg overview and Burg Edit)

@Legogizmo
Copy link
Contributor Author

Ok, I'll fix it up and update.

@Legogizmo
Copy link
Contributor Author

Legogizmo commented Mar 28, 2021

Fixed the tool tips to be a bit more descriptive and Updated existing tool tips to mention they would only modify unlocked burgs.
Added the pointer tag.
Cultures Editor no longer renames locked burgs.
Also managed to prevent burg group removal from removing locked burgs.

@Azgaar
Copy link
Owner

Azgaar commented Mar 29, 2021

Thanks! Reviewing and merging is everything is good :)

@Azgaar Azgaar merged commit f855de6 into Azgaar:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants