Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable calculateScrollForSelectingPosition() function #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to disable calculateScrollForSelectingPosition() function #68

wants to merge 2 commits into from

Conversation

nltimv
Copy link

@nltimv nltimv commented Apr 16, 2018 •
edited
Loading

This code fixes the problem in issue #23 and allows you to disable the calculateScrollForSelectingPosition() function in the constructor with the calculateScroll argument.

@mig35
Copy link
Member

mig35 commented Apr 18, 2018

@nltimv can you give me full project with issue #23 so I can look. Above change will result strange behavior when you will add or remove items in adapter with notifyItem* call.

@jpvs0101
Copy link

@mig35 is absolutely right! I tested it!

@jpvs0101 jpvs0101 mentioned this pull request Jun 26, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge needs info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nltimv @mig35 @jpvs0101