list yearn bridge for both deposit/withdraw, as gas differs #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
requested changes
Aug 31, 2022
| @@ -49,7 +49,8 @@ abstract contract BaseDeployment is Test { | |||
| bool envMode = vm.envBool(modeKey); | |||
| MODE = envMode ? Mode.BROADCAST : Mode.SIMULATE; | |||
|
|
|||
| bytes32 envNetwork = keccak256(abi.encodePacked(vm.envString(networkKey))); | |||
| string memory nw = vm.envString(networkKey); | |||
| bytes32 envNetwork = keccak256(abi.encodePacked(nw)); | |||
There was a problem hiding this comment.
I think better naming here would be string memory envNetwork and bytes32 envNetworkHash.
| deal(underlyingToken, address(_vault), _depositAmount / 2); | ||
| } | ||
|
|
||
| uint256 _withdrawAmount = outputAssetAMid; |
There was a problem hiding this comment.
Please use underscores only for params.
| @@ -154,8 +178,20 @@ contract YearnBridgeE2ETest is BridgeTestBase { | |||
| assertEq(inputAssetAMid, inputAssetABefore - _depositAmount, "Balance missmatch after deposit"); | |||
| assertGt(outputAssetAMid, outputAssetABefore, "No change in output asset balance after deposit"); | |||
|
|
|||
| _withdrawAmount = outputAssetAMid; | |||
| bridgeCallData = encodeBridgeCallData(id, depositOutputAssetA, emptyAsset, depositInputAssetA, emptyAsset, 1); | |||
| // Move some funds to strategies to have underlying balance be less than the required. | |||
There was a problem hiding this comment.
I don't fully understand this. Is this supposed to cause revert or something else? Please expand a bit on what this will achieve.
benesjan
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gas constraints in the yearn tests + deployment.
Checklist:
forge coverage --match-contract MyContractreturns 100% line coverage.