Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient interactionNonce -> ethTxHash #232

Merged

Conversation

joss-aztec
Copy link
Contributor

Description

Fetch the eth tx hash for a given interaction nonce via falafel instead of scanning for it via infura.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@LHerskind LHerskind merged commit 2e5ce82 into AztecProtocol:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants