Skip to content

Commit

Permalink
fix: Ensuring translator range constraint polynomials are zeroes outs…
Browse files Browse the repository at this point in the history 
…ide of minicircuit (#9251)

When Translator was built, there was expectation on using ZM's degree
checks for minicircuit polynomials later. ZM is dead, so we have to
enforce those in another way so there is no soundness issue during
polynomial concatenation. This PR adds relations to ensure
range_constraint polynomials are zero outside of minicircuit

ClientIVC before:

![image](https://github.com/user-attachments/assets/6299f04b-41de-4f41-90e4-45e49bf42470)
ClientIVC after:

![image](https://github.com/user-attachments/assets/5b0c8677-ee3f-4195-898e-892ef38e9eef)

Fixes AztecProtocol/barretenberg#1128
  • Loading branch information
@Rumata888
Rumata888 authored Oct 31, 2024
1 parent 755c70a commit 04dd2c4
Show file tree
Hide file tree
Showing 6 changed files with 719 additions and 4 deletions.
3 changes: 3 additions & 0 deletions barretenberg/cpp/src/barretenberg/relations/translator_vm/translator_extra_relations.cpp
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
#include "barretenberg/relations/translator_vm/translator_extra_relations.hpp"
#include "barretenberg/relations/translator_vm/translator_extra_relations_impl.hpp"
#include "barretenberg/translator_vm/translator_flavor.hpp"
namespace bb {
template class TranslatorOpcodeConstraintRelationImpl<fr>;
template class TranslatorAccumulatorTransferRelationImpl<fr>;
template class TranslatorZeroConstraintsRelationImpl<fr>;

DEFINE_ZK_SUMCHECK_RELATION_CLASS(TranslatorOpcodeConstraintRelationImpl, TranslatorFlavor);
DEFINE_ZK_SUMCHECK_RELATION_CLASS(TranslatorAccumulatorTransferRelationImpl, TranslatorFlavor);
DEFINE_ZK_SUMCHECK_RELATION_CLASS(TranslatorZeroConstraintsRelationImpl, TranslatorFlavor);
} // namespace bb
176 changes: 176 additions & 0 deletions barretenberg/cpp/src/barretenberg/relations/translator_vm/translator_extra_relations.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,185 @@ polynomials,
const FF& scaling_factor);
};

template <typename FF_> class TranslatorZeroConstraintsRelationImpl {
public:
using FF = FF_;

// 1 + polynomial degree of this relation
static constexpr size_t RELATION_LENGTH = 3; // degree((some lagrange)(A)) = 2

static constexpr size_t ZK_RELATION_LENGTH = 5;
static constexpr std::array<size_t, 64> SUBRELATION_PARTIAL_LENGTHS{
3, // p_x_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_0 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_1 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_2 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_3 is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_4 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_0 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_1 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_2 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_3 is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_4 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_0 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_1 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_2 is zero outside of the minicircuit
3, // relation_wide_limbs_range_constraint_3 is zero outside of the minicircuit
3, // p_x_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // p_x_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // p_y_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // p_y_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // z_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // z_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // accumulator_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // accumulator_high_limbs_range_constraint_tail is zero outside of the minicircuit
3, // quotient_low_limbs_range_constraint_tail is zero outside of the minicircuit
3, // quotient_high_limbs_range_constraint_tail is zero outside of the minicircuit

};
/**
* @brief For ZK-Flavors: Upper bound on the degrees of subrelations considered as polynomials only in witness
polynomials,
* i.e. all selectors and public polynomials are treated as constants. The subrelation witness degree does not
* exceed the subrelation partial degree given by SUBRELATION_PARTIAL_LENGTH - 1.
*/
static constexpr std::array<size_t, 64> SUBRELATION_WITNESS_DEGREES{
2, // p_x_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_0 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_1 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_2 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_3 is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_4 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_0 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_1 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_2 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_3 is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_4 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_0 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_1 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_2 is zero outside of the minicircuit
2, // relation_wide_limbs_range_constraint_3 is zero outside of the minicircuit
2, // p_x_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // p_x_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // p_y_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // p_y_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // z_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // z_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // accumulator_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // accumulator_high_limbs_range_constraint_tail is zero outside of the minicircuit
2, // quotient_low_limbs_range_constraint_tail is zero outside of the minicircuit
2, // quotient_high_limbs_range_constraint_tail is zero outside of the minicircuit

};
/**
* @brief Might return true if the contribution from all subrelations for the provided inputs is identically zero
*
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
{
static constexpr auto minus_one = -FF(1);
return (in.lagrange_even_in_minicircuit + in.lagrange_second_to_last_in_minicircuit + minus_one).is_zero();
}
/**
* @brief Relation enforcing all the range-constraint polynomials to be zero after the minicircuit
* @details This relation ensures that while we are out of the minicircuit the range constraint polynomials are zero
*
* @param evals transformed to `evals + C(in(X)...)*scaling_factor`
* @param in an std::array containing the fully extended Univariate edges.
* @param parameters contains beta, gamma, and public_input_delta, ....
* @param scaling_factor optional term to scale the evaluation before adding to evals.
*/
template <typename ContainerOverSubrelations, typename AllEntities, typename Parameters>
static void accumulate(ContainerOverSubrelations& accumulators,
const AllEntities& in,
const Parameters& params,
const FF& scaling_factor);
};

template <typename FF> using TranslatorOpcodeConstraintRelation = Relation<TranslatorOpcodeConstraintRelationImpl<FF>>;

template <typename FF>
using TranslatorAccumulatorTransferRelation = Relation<TranslatorAccumulatorTransferRelationImpl<FF>>;

template <typename FF> using TranslatorZeroConstraintsRelation = Relation<TranslatorZeroConstraintsRelationImpl<FF>>;

} // namespace bb
Loading

0 comments on commit 04dd2c4

Please sign in to comment.