Skip to content

Commit

Permalink
fix(avm): mac build (retry) (#11197)
Browse files Browse the repository at this point in the history
Please read [contributing guidelines](CONTRIBUTING.md) and remove this line.
  • Loading branch information
fcarreiro authored Jan 13, 2025
1 parent 3092212 commit 0a4b763
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void Execution::ret(ContextInterface& context, MemoryAddress ret_offset, MemoryA
auto& memory = context.get_memory();

// TODO: check tags and types (only for size, the return data is converted to FF).
size_t size = static_cast<size_t>(memory.get(ret_size_offset).value);
uint32_t size = static_cast<uint32_t>(memory.get(ret_size_offset).value);
auto [values, _] = memory.get_slice(ret_offset, size);

context_stack.pop();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#include <cassert>
#include <cstdint>
#include <format>
#include <iomanip>
#include <span>
#include <sstream>
Expand Down Expand Up @@ -456,7 +455,7 @@ Instruction decode_instruction(std::span<const uint8_t> bytecode, size_t pos)
std::string Instruction::to_string() const
{
std::ostringstream oss;
oss << opcode << " indirect: " << std::format("{:b}", indirect) << ", operands: [ ";
oss << opcode << " indirect: " << indirect << ", operands: [ ";
for (const auto& operand : operands) {
oss << operand.to_string() << " ";
}
Expand Down

1 comment on commit 0a4b763

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 0a4b763 Previous: 3092212 Ratio
Goblin::merge(t) 152752627 ns/iter 143002881 ns/iter 1.07

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.