feat(avm): make ProverPolynomials::get_row return references (#7419)

This makes the computation of logderivatives ~20x faster, and proving a public token transfer goes from `60s` to `14s`. The cost is verbosity.
AztecProtocol · Jul 10, 2024 · 108fc5f · 108fc5f
1 parent ebec8ff
commit 108fc5f
Show file tree

Hide file tree

Showing 3 changed files with 1,404 additions and 27 deletions.
diff --git a/barretenberg/cpp/src/barretenberg/common/ref_array.hpp b/barretenberg/cpp/src/barretenberg/common/ref_array.hpp
@@ -24,9 +24,8 @@ template <typename T, std::size_t N> class RefArray {
     RefArray() = default;
     RefArray(const std::array<T*, N>& ptr_array)
     {
-        std::size_t i = 0;
-        for (T& elem : ptr_array) {
-            storage[i++] = &elem;
+        for (std::size_t i = 0; i < N; ++i) {
+            storage[i++] = ptr_array[i];
         }
     }
     template <typename... Ts> RefArray(T& ref, Ts&... rest)