verifying final ultra proof

AztecProtocol · Dec 7, 2023 · 1af36d7 · 1af36d7
1 parent 46e56ad
commit 1af36d7
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/barretenberg/cpp/src/barretenberg/goblin/full_goblin_recursion.test.cpp b/barretenberg/cpp/src/barretenberg/goblin/full_goblin_recursion.test.cpp
@@ -36,6 +36,7 @@ class GoblinRecursionTests : public ::testing::Test {
     using RecursiveVerifier = proof_system::plonk::stdlib::recursion::honk::UltraRecursiveVerifier_<RecursiveFlavor>;
     using Goblin = barretenberg::Goblin;
     using KernelInput = Goblin::AccumulationOutput;
+    using UltraVerifier = UltraVerifier_<flavor::GoblinUltra>;
 
     /**
      * @brief Construct a mock kernel circuit
@@ -87,9 +88,12 @@ TEST_F(GoblinRecursionTests, Pseudo)
     }
 
     Goblin::Proof proof = goblin.prove();
-    // WORKTODO: verify(kernel_input.proof)
+    // Verify the final ultra proof
+    UltraVerifier ultra_verifier{ kernel_input.verification_key };
+    bool ultra_verified = ultra_verifier.verify_proof(kernel_input.proof);
+    // Verify the goblin proof (eccvm, translator, merge)
     bool verified = goblin.verify(proof);
-    EXPECT_TRUE(verified);
+    EXPECT_TRUE(ultra_verified && verified);
 }
 
 // TODO(https://github.com/AztecProtocol/barretenberg/issues/787) Expand these tests.

diff --git a/barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp b/barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.cpp
@@ -15,6 +15,13 @@ UltraVerifier_<Flavor>::UltraVerifier_(const std::shared_ptr<Transcript>& transc
     , transcript(transcript)
 {}
 
+template <typename Flavor>
+UltraVerifier_<Flavor>::UltraVerifier_(const std::shared_ptr<VerificationKey>& verifier_key)
+    : key(verifier_key)
+    , pcs_verification_key(std::make_unique<VerifierCommitmentKey>(0, barretenberg::srs::get_crs_factory()))
+    , transcript(std::make_shared<Transcript>())
+{}
+
 template <typename Flavor>
 UltraVerifier_<Flavor>::UltraVerifier_(UltraVerifier_&& other)
     : key(std::move(other.key))

diff --git a/barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.hpp b/barretenberg/cpp/src/barretenberg/ultra_honk/ultra_verifier.hpp
@@ -2,6 +2,7 @@
 #include "barretenberg/flavor/goblin_ultra.hpp"
 #include "barretenberg/flavor/ultra.hpp"
 #include "barretenberg/plonk/proof_system/types/proof.hpp"
+#include "barretenberg/srs/global_crs.hpp"
 #include "barretenberg/sumcheck/sumcheck.hpp"
 
 namespace proof_system::honk {
@@ -15,6 +16,7 @@ template <typename Flavor> class UltraVerifier_ {
   public:
     explicit UltraVerifier_(const std::shared_ptr<Transcript>& transcript,
                             const std::shared_ptr<VerificationKey>& verifier_key = nullptr);
+    explicit UltraVerifier_(const std::shared_ptr<VerificationKey>& verifier_key);
     UltraVerifier_(UltraVerifier_&& other);
 
     UltraVerifier_& operator=(const UltraVerifier_& other) = delete;