1073 - jeanmon review's comment

AztecProtocol · Jul 18, 2023 · 3b3eccb · 3b3eccb
1 parent 351972e
commit 3b3eccb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp b/circuits/cpp/src/aztec3/circuits/kernel/private/common.cpp
@@ -191,8 +191,8 @@ void common_update_end_values(DummyBuilder& builder,
     // We silo the read requests (domain separation per contract address)
     {
         for (size_t i = 0; i < read_requests.size(); ++i) {
-            const auto read_request = read_requests[i];
-            const auto witness = read_request_membership_witnesses[i];
+            const auto& read_request = read_requests[i];
+            const auto& witness = read_request_membership_witnesses[i];
             if (witness.is_transient) {  // only forward transient to public inputs
                 const auto siloed_read_request =
                     read_request == 0 ? 0 : silo_commitment<NT>(storage_contract_address, read_request);

diff --git a/circuits/cpp/src/aztec3/utils/array.hpp b/circuits/cpp/src/aztec3/utils/array.hpp
@@ -118,6 +118,7 @@ template <typename T, size_t SIZE> void array_rearrange(std::array<T, SIZE>& arr
         } else {
             if (!arr[i].is_empty()) {
                 arr[target_pos] = arr[i];
+                target_pos++;
             }
         }
     }