Skip to content

Commit

Permalink
slither
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan committed Mar 21, 2024
1 parent 62dc0a2 commit 64bcffa
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions l1-contracts/slither_output.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,34 +57,27 @@ src/core/libraries/decoders/MessagesDecoder.sol#L126-L128


- [ ] ID-5
Dubious typecast in [Outbox.sendL1Messages(bytes32[])](src/core/messagebridge/Outbox.sol#L38-L46):
uint256 => uint32 casting occurs in [version = uint32(REGISTRY.getVersionFor(msg.sender))](src/core/messagebridge/Outbox.sol#L40)

src/core/messagebridge/Outbox.sol#L38-L46


- [ ] ID-6
Dubious typecast in [TxsDecoder.read1(bytes,uint256)](src/core/libraries/decoders/TxsDecoder.sol#L333-L335):
bytes => bytes1 casting occurs in [uint256(uint8(bytes1(slice(_data,_offset,1))))](src/core/libraries/decoders/TxsDecoder.sol#L334)

src/core/libraries/decoders/TxsDecoder.sol#L333-L335


- [ ] ID-7
- [ ] ID-6
Dubious typecast in [MessagesDecoder.read4(bytes,uint256)](src/core/libraries/decoders/MessagesDecoder.sol#L136-L138):
bytes => bytes4 casting occurs in [uint256(uint32(bytes4(_data)))](src/core/libraries/decoders/MessagesDecoder.sol#L137)

src/core/libraries/decoders/MessagesDecoder.sol#L136-L138


- [ ] ID-8
- [ ] ID-7
Dubious typecast in [TxsDecoder.read4(bytes,uint256)](src/core/libraries/decoders/TxsDecoder.sol#L343-L345):
bytes => bytes4 casting occurs in [uint256(uint32(bytes4(slice(_data,_offset,4))))](src/core/libraries/decoders/TxsDecoder.sol#L344)

src/core/libraries/decoders/TxsDecoder.sol#L343-L345


- [ ] ID-9
- [ ] ID-8
Dubious typecast in [HeaderLib.decode(bytes)](src/core/libraries/HeaderLib.sol#L143-L184):
bytes => bytes32 casting occurs in [header.lastArchive = AppendOnlyTreeSnapshot(bytes32(_header),uint32(bytes4(_header)))](src/core/libraries/HeaderLib.sol#L151-L153)
bytes => bytes4 casting occurs in [header.lastArchive = AppendOnlyTreeSnapshot(bytes32(_header),uint32(bytes4(_header)))](src/core/libraries/HeaderLib.sol#L151-L153)
Expand Down Expand Up @@ -203,14 +196,14 @@ src/core/messagebridge/Outbox.sol#L18-L132
## assembly
Impact: Informational
Confidence: High
- [ ] ID-21
- [ ] ID-19
[TxsDecoder.computeRoot(bytes32[])](src/core/libraries/decoders/TxsDecoder.sol#L257-L276) uses assembly
- [INLINE ASM](src/core/libraries/decoders/TxsDecoder.sol#L264-L266)

src/core/libraries/decoders/TxsDecoder.sol#L257-L276


- [ ] ID-22
- [ ] ID-20
[MessagesDecoder.decode(bytes)](src/core/libraries/decoders/MessagesDecoder.sol#L53-L118) uses assembly
- [INLINE ASM](src/core/libraries/decoders/MessagesDecoder.sol#L89-L95)

Expand Down

0 comments on commit 64bcffa

Please sign in to comment.