Skip to content

Commit

Permalink
fix(avm): full proving kernel fix (#8468)
Browse files Browse the repository at this point in the history
Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.
  • Loading branch information
IlyasRidhuan authored Sep 10, 2024
1 parent bff0338 commit 684d962
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2113,9 +2113,9 @@ TEST_F(AvmExecutionTests, kernelOutputHashExistsOpcodes)
trace.begin(), trace.end(), [&](Row r) { return r.main_clk == START_NULLIFIER_EXISTS_OFFSET; });
EXPECT_EQ(nullifier_out_row->main_kernel_value_out, 1); // value
// TODO(#8287)
// EXPECT_EQ(nullifier_out_row->main_kernel_side_effect_out, 1);
EXPECT_EQ(nullifier_out_row->main_kernel_side_effect_out, 0);
EXPECT_EQ(nullifier_out_row->main_kernel_metadata_out, 1); // exists
feed_output(START_NULLIFIER_EXISTS_OFFSET, 1, 1, 1);
feed_output(START_NULLIFIER_EXISTS_OFFSET, 1, 0, 1);

// CHECK L1TOL2MSGEXISTS
auto l1_to_l2_row =
Expand All @@ -2128,9 +2128,9 @@ TEST_F(AvmExecutionTests, kernelOutputHashExistsOpcodes)
trace.begin(), trace.end(), [&](Row r) { return r.main_clk == START_L1_TO_L2_MSG_EXISTS_WRITE_OFFSET; });
EXPECT_EQ(msg_out_row->main_kernel_value_out, 1); // value
// TODO(#8287)
// EXPECT_EQ(msg_out_row->main_kernel_side_effect_out, 2);
EXPECT_EQ(msg_out_row->main_kernel_side_effect_out, 0);
EXPECT_EQ(msg_out_row->main_kernel_metadata_out, 1); // exists
feed_output(START_L1_TO_L2_MSG_EXISTS_WRITE_OFFSET, 1, 2, 1);
feed_output(START_L1_TO_L2_MSG_EXISTS_WRITE_OFFSET, 1, 0, 1);

validate_trace(std::move(trace), public_inputs);
}
Expand Down

0 comments on commit 684d962

Please sign in to comment.