Apply suggestions from code review

AztecProtocol · May 20, 2024 · b1ef289 · b1ef289
1 parent ee28ff0
commit b1ef289
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/docs/docs/protocol-specs/constants.md b/docs/docs/protocol-specs/constants.md
@@ -52,7 +52,7 @@ The statically-sized nature the kernel & rollup circuits will restrict the quant
 | `MAX_ENCRYPTED_NOTE_PREIMAGE_HASHES_PER_CALL` | 128 |
 | `MAX_NOTE_HASH_READ_REQUESTS_PER_CALL` | 128 |
 | `MAX_NULLIFIER_READ_REQUESTS_PER_CALL` | 128 |
-| `MAX_KEY_VALIDATION_REQUESTS_PER_CALL | 1 | TODO: we shouldn't need this, given the reset circuit. |
+| `MAX_KEY_VALIDATION_REQUESTS_PER_CALL | 16 | TODO: we shouldn't need this, given the reset circuit. |
 | `MAX_PRIVATE_CALL_STACK_LENGTH_PER_CALL` | 32 |
 | `MAX_PUBLIC_CALL_STACK_LENGTH_PER_CALL` | 32 |
 
@@ -71,7 +71,7 @@ The statically-sized nature the kernel & rollup circuits will restrict the quant
 | `MAX_ENCRYPTED_NOTE_PREIMAGE_HASHES_PER_TX` | 128 |
 | `MAX_OPTIONALLY_REVEALED_DATA_LENGTH_PER_TX` | 4 |
 | `MAX_NOTE_HASH_READ_REQUESTS_PER_TX` | 128 | TODO: we shouldn't need this, given the reset circuit. |
-| `MAX_KEY_VALIDATION_REQUESTS_PER_TX` | 4 | TODO: we shouldn't need this, given the reset circuit. |
+| `MAX_KEY_VALIDATION_REQUESTS_PER_TX` | 64 | TODO: we shouldn't need this, given the reset circuit. |
 | `MAX_PRIVATE_CALL_STACK_LENGTH_PER_TX` | 32 |
 | `MAX_PUBLIC_CALL_STACK_LENGTH_PER_TX` | 32 |
 

diff --git a/noir-projects/aztec-nr/aztec/src/oracle/key_validation_request.nr b/noir-projects/aztec-nr/aztec/src/oracle/key_validation_request.nr
@@ -4,7 +4,7 @@ use dep::protocol_types::{
 };
 
 #[oracle(getKeyValidationRequest)]
-fn get_key_validation_request_oracle(_npk_m_hash: Field, _key_index: Field) -> [Field; KEY_VALIDATION_REQUEST_LENGTH] {}
+fn get_key_validation_request_oracle(_pk_m_hash: Field, _key_index: Field) -> [Field; KEY_VALIDATION_REQUEST_LENGTH] {}
 
 unconstrained fn get_key_validation_request_internal(npk_m_hash: Field, key_index: Field) -> KeyValidationRequest {
     let result = get_key_validation_request_oracle(npk_m_hash, key_index);

diff --git a/yarn-project/pxe/src/kernel_oracle/index.ts b/yarn-project/pxe/src/kernel_oracle/index.ts
@@ -69,8 +69,8 @@ export class KernelOracle implements ProvingDataOracle {
     return header.state.partial.noteHashTree.root;
   }
 
-  public getMasterSecretKeyAndAppKeyGenerator(nullifierPublicKey: Point): Promise<[GrumpkinPrivateKey, KeyGenerator]> {
-    return this.keyStore.getMasterSecretKeyAndAppKeyGenerator(nullifierPublicKey);
+  public getMasterSecretKeyAndAppKeyGenerator(masterPublicKey: Point): Promise<[GrumpkinPrivateKey, KeyGenerator]> {
+    return this.keyStore.getMasterSecretKeyAndAppKeyGenerator(masterPublicKey);
   }
 
   public async getFunctionName(contractAddress: AztecAddress, selector: FunctionSelector): Promise<string | undefined> {