Skip to content

Commit

Permalink
fix(ci): try fix brotli edge-case (#8256)
Browse files Browse the repository at this point in the history
seemingly not running apt install in this case
  • Loading branch information
ludamad authored Aug 28, 2024
1 parent 00ed045 commit e03ea0b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/spot-runner-action/src/userdata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export class UserData {
`sudo service docker restart`,
"sudo wget -q https://github.com/earthly/earthly/releases/download/v0.8.10/earthly-linux-$(dpkg --print-architecture) -O /usr/local/bin/earthly",
"sudo chmod +x /usr/local/bin/earthly",
"for i in {1..3} ; do sudo apt install -y brotli && break; sleep 10; done",
`sudo bash -c 'echo \'Acquire::Retries "3"; Acquire::https::Timeout "240"; Acquire::http::Timeout "240"; APT::Get::Assume-Yes "true"; APT::Install-Recommends "false"; APT::Install-Suggests "false";\' > /etc/apt/apt.conf.d/99-aztec-build'`,
"sudo apt install -y brotli",
'echo "MaxStartups 1000" >> /etc/ssh/sshd_config',
'echo "ClientAliveInterval=30" >> /etc/ssh/sshd_config',
'echo "ClientAliveCountMax=20" >> /etc/ssh/sshd_config',
Expand All @@ -35,4 +36,4 @@ export class UserData {
);
return Buffer.from(cmds.join("\n")).toString("base64");
}
}
}
2 changes: 1 addition & 1 deletion yarn-project/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ COMMIT_TAG=<RELEASE_TAG_NUMBER_YOU_WANT e.g. aztec-packages-v0.8.8>
- Best to run the `deploy_package()` method line by line by manually setting `REPOSITORY` var.
- Extract `VERSION` as the script shows (in the eg it should be 0.8.8)
- Skip the version existing checks like `if [ "$VERSION" == "$PUBLISHED_VERSION" ]` and `if [ "$VERSION" != "$HIGHER_VERSION" ]`. Since this is our first time deploying the package, `PUBLISHED_VERSION` and `HIGHER_VERSION` will be empty and hence these checks would fail. These checks are necessary in the CI for continual releases.
- Locally update the package version in package.json using `jq` as shown in the script
- Locally update the package version in package.json using `jq` as shown in the script.
- Do a dry-run
- If dry run succeeds, publish the package!
5. Create a PR by adding your package into the `deploy-npm` script so next release onwards, CI can cut releases for your package.

0 comments on commit e03ea0b

Please sign in to comment.