Skip to content

Commit

Permalink
test(avm): fix proving for kernel tests (#7033)
Browse files Browse the repository at this point in the history
  • Loading branch information
fcarreiro authored Jun 12, 2024
1 parent ee45fda commit f5e1106
Show file tree
Hide file tree
Showing 5 changed files with 124 additions and 104 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ bool is_operand_indirect(uint8_t ind_value, uint8_t operand_idx)
return static_cast<bool>((ind_value & (1 << operand_idx)) >> operand_idx);
}

std::vector<std::vector<FF>> copy_public_inputs_columns(VmPublicInputs public_inputs)
std::vector<std::vector<FF>> copy_public_inputs_columns(VmPublicInputs const& public_inputs)
{
// We convert to a vector as the pil generated verifier is generic and unaware of the KERNEL_INPUTS_LENGTH
// For each of the public input vectors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ bool is_operand_indirect(uint8_t ind_value, uint8_t operand_idx);
// There are 4 public input columns, one for inputs, and 3 for the kernel outputs {value, side effect counter, metadata}
// The verifier is generic, and so accepts vectors of these values rather than the fixed length arrays that are used
// during circuit building. This method copies each array into a vector to be used by the verifier.
std::vector<std::vector<FF>> copy_public_inputs_columns(VmPublicInputs public_inputs);
std::vector<std::vector<FF>> copy_public_inputs_columns(VmPublicInputs const& public_inputs);

} // namespace bb::avm_trace
Loading

0 comments on commit f5e1106

Please sign in to comment.