Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: create a build step for noir contract artifacts #1248

Closed
Maddiaa0 opened this issue Jul 27, 2023 · 0 comments · Fixed by #1251
Closed

ci: create a build step for noir contract artifacts #1248

Maddiaa0 opened this issue Jul 27, 2023 · 0 comments · Fixed by #1251
Assignees
@Maddiaa0

Comments

@Maddiaa0
Copy link
Member

Currently noir artifact rebuilding is halting alot of prs with merge issues, instead these artifacts should be built as part of the ci pipeline.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 27, 2023
@Maddiaa0 Maddiaa0 self-assigned this Jul 27, 2023
@Maddiaa0 Maddiaa0 moved this from Todo to In Progress in A3 Jul 27, 2023
@Maddiaa0 Maddiaa0 mentioned this issue Jul 31, 2023
Merged
6 tasks
Maddiaa0 added a commit that referenced this issue Jul 31, 2023
@Maddiaa0 @ludamad
feat(ci): build noir artifacts in ci (#1251)
02c05f8 
# Description

closes: #1248

- Adds a build step before yarn project base that compiles the noir
contracts using the nightly compiler version.
- Adds an ephemeral layer to yarn project base to process the noir
artifacts.

## Dependencies
Uses the following build system pr in order to use multi stage builds of
yarn project base.
AztecProtocol/build-system#16

# Checklist:

- [x] I have reviewed my diff in github, line by line.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [x] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.

---------

Co-authored-by: ludamad <adam.domurad@gmail.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Jul 31, 2023
@Maddiaa0 Maddiaa0 removed this from A3 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maddiaa0 Maddiaa0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ci): build noir artifacts in ci AztecProtocol/aztec-packages
1 participant
@Maddiaa0