Fix barretenberg release please to use clang16 #1698
Assignees
Comments
4 tasks
kevaundray
added a commit
that referenced
this issue
Aug 21, 2023
resolves #1698 Code taken from @ludamad -- I tested it on a fork to make sure it compiles. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
codygunton
pushed a commit
that referenced
this issue
Jan 23, 2024
* Attempt to fix production deployment (#1683) * Add stefan to mainframe. Deployment publishes bb.js and blockchain to npm. * Fix block scanning (#1692) * Attempt to fix deploy. * Fix dai-permit issues. Providers did not offset `v` properly (#1698) * fix: perform offset to `sig.v if 0 or 1 for `signTypedData` * fix: remove git-submodules * Force to -O2 with binaryen installed to prevent aes bug. * Updated fork block number (#1685) * Updated fork block number * Updated fork block and element test tranche * Removed no longer used env variable * Updated Faucet index page amounts * [zk-money] Jcf/aave (#1642) * Configure aave defi cards * copy-paste error * Increase test timeout Co-authored-by: PhilWindle <philip.windle@gmail.com> * fix aave token addresses (#1701) * Fuzzer-found bugs that are not related to bigfield (#1605) * Added a regression test to detect original parallelized asm bugs * FIxed parallelized SQR asm bugs * Added comment that Emerson wanted * Fix for create_range_constraint in the constant case * Various safe_uint bug fixes having to do with not handling constant cases * Fixed the comparison issue for the point at infinity * Added regression tests and fixed 3 more missing flags in optimized SQR * Fixed tabulation in asm_macros.hpp * Fixed Montgomery Issue that Adrian Found * Fixed issue with negative zero found by Guido * FIxed same self_neg bug found by Guido * Renamed 1 test * Fixed one more SQR bug * Added extra regression tests * Slightly moved one test * Added TODO comments into field_impl for potential optimisations * Addressed Zac's comments Co-authored-by: zac-williamson <blorktronics@gmail.com> * Fixing errors in addition and subtraction of field elements with moduli > 254 bits (#1702) * Added test * Added bugfixes * Added comments * Use 400k gas bridge for aave (#1705) * Add versioning to falafel status endpoint. Refresh zk-money on version mismatch. (#1674) * all get/post reqs from sdk to falafel now include header * falafel expects all endpoint requests to be given a 'version' header. SDK now gives all reqs a version. If falafel sees a req with version that does not match falafel version, it responds with error 402. ServerRollupProvider now emits versionMismatch whenever one occurs. zk-money promotes this event and forces refresh of browser. * cleanup new FALAFEL_VERSION constant in falafel - using configurator everywhere instead of using constant directly * fix prettier errors * prettier server.ts * sdk version to 0 * version is now a str like 2.1.0 in falafel and sdk. moved getRollupProviderStatus into SDK so that it doesn't need to accept sdk_version as arg * prettier sdk index.ts * zk-money alerts on version mismatch. Falafel allows requests without version header, but if version header is present it enforces a match. * server rollup provider and block source shouldn't NEED a to interact with falafel. * prettier rollup provider ts * block source / provider fix version default undefined changed to '' Co-authored-by: joss-aztec <94053499+joss-aztec@users.noreply.github.com> Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Lasse Herskind <16536249+LHerskind@users.noreply.github.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: zac-williamson <blorktronics@gmail.com> Co-authored-by: David Banks <47112877+dbanks12@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, it errors on release please linux build https://github.com/AztecProtocol/barretenberg/actions/runs/5925691485/job/16065611468
A bigger issue is: how can we test this github action locally so its not unproductive?
The text was updated successfully, but these errors were encountered: