Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use type PrivateKernelPublicInputs in TS or remove #1879

Closed
jeanmon opened this issue Aug 30, 2023 · 0 comments · Fixed by #1911
Closed

chore: use type PrivateKernelPublicInputs in TS or remove #1879

jeanmon opened this issue Aug 30, 2023 · 0 comments · Fixed by #1911
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Aug 30, 2023

PrivateKernelPublicInputs is never used as the counterpart PrivateKernelPublicInputsFinal. On the other hand, the public counterpart PublicKernelPublicInputs is extensively used.
@jeanmon jeanmon added C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring labels Aug 30, 2023
@jeanmon jeanmon self-assigned this Aug 30, 2023
@jeanmon jeanmon added this to A3 Aug 30, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 30, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Aug 31, 2023
This was referenced Aug 31, 2023
Merged
Closed
jeanmon added a commit that referenced this issue Aug 31, 2023
@jeanmon
chore(1879): add use of PrivateKernelPublicInputs in TS whenever rele…
8d5f548 
…vant (#1911)

Resolves #1879 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Aug 31, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@Rumata888
Some changes to make 32-bit build work (#1879)
cbb08c1 
* Almost finished preparing for i386

* FInished making 32-bit cross-compilation work. Testing is next

* Explicitly converting to bool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@jeanmon