Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possible race condition in (at least) e2e-lending-contract #1950

Closed
ludamad opened this issue Sep 2, 2023 · 1 comment
Closed
Labels
T-bug Type: Bug. Something is broken.

Comments

@ludamad
Copy link
Collaborator

ludamad commented Sep 2, 2023

This seems to fail intermittently: https://app.circleci.com/pipelines/github/AztecProtocol/aztec-packages/8827/workflows/dec16464-4e5b-4b0e-8c02-e14fdd3fcb33/jobs/300406

end-to-end_1  | FAIL src/e2e_lending_contract.test.ts (77.972 s)
end-to-end_1  |   e2e_lending_contract
end-to-end_1  |     ✕ Full lending run-through (70762 ms)
end-to-end_1  | 
end-to-end_1  |   ● e2e_lending_contract › Full lending run-through
end-to-end_1  | 
end-to-end_1  |     expect(received).toEqual(expected) // deep equality
end-to-end_1  | 
end-to-end_1  |     - Expected  - 1
end-to-end_1  |     + Received  + 1
end-to-end_1  | 
end-to-end_1  |       Fr {
end-to-end_1  |     -   "value": 0n,
end-to-end_1  |     +   "value": 420n,
end-to-end_1  |       }
end-to-end_1  | 
end-to-end_1  |       237 |       // Public values
end-to-end_1  |       238 |       const keyPub = this.account.address.toString();
end-to-end_1  |     > 239 |       expect(storage['publicCollateral']).toEqual(this.collateral[keyPub] ?? Fr.ZERO);
end-to-end_1  |           |                                           ^
end-to-end_1  |       240 |       expect(storage['publicStaticDebt']).toEqual(this.staticDebt[keyPub] ?? Fr.ZERO);
end-to-end_1  |       241 |       expect(storage['publicDebt'].value).toEqual(
end-to-end_1  |       242 |         muldivUp((this.staticDebt[keyPub] ?? Fr.ZERO).value, this.accumulator, BASE),
end-to-end_1  | 
end-to-end_1  |       at LendingSimulator.check (e2e_lending_contract.test.ts:239:43)
end-to-end_1  |       at Object.<anonymous> (e2e_lending_contract.test.ts:373:18)
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 2, 2023
@ludamad ludamad added the T-bug Type: Bug. Something is broken. label Sep 2, 2023
@kevaundray
Copy link
Contributor

Linking #1835 incase the issue is the same

@ludamad ludamad closed this as completed Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bug. Something is broken.
Projects
Archived in project
Development

No branches or pull requests

2 participants