Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "artifact" instead of "abi" to refer to the JSON file that the contract compiler spits out #2101

Closed
iAmMichaelConnor opened this issue Sep 7, 2023 · 0 comments · Fixed by #2756
Closed

Use "artifact" instead of "abi" to refer to the JSON file that the contract compiler spits out #2101

iAmMichaelConnor opened this issue Sep 7, 2023 · 0 comments · Fixed by #2756
Assignees
@benesjan
Labels
T-refactor Type: this code needs refactoring

Comments

@iAmMichaelConnor
Copy link
Contributor

iAmMichaelConnor commented Sep 7, 2023 •
edited by benesjan
Loading

"ABI" is quite overloaded. "Artifact" is consistently used in Ethereum land. Use this name consistently everywhere (docs, code, etc).

Re spelling: google tells me "artifact" (rather than "artefact") is the correct American spelling. My spell checker isn't happy about this.
@iAmMichaelConnor iAmMichaelConnor added the T-refactor Type: this code needs refactoring label Sep 7, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 7, 2023
@benesjan benesjan mentioned this issue Sep 25, 2023
Closed
@benesjan benesjan self-assigned this Oct 10, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Oct 10, 2023
@benesjan benesjan mentioned this issue Oct 10, 2023
Merged
4 tasks
benesjan added a commit that referenced this issue Oct 11, 2023
@benesjan
refactor: renaming abi as artifact (#2756)
c0abcfd 
Fixes #2101

Note: In some places it made sense to use the ABI term because it really
referred to what ABI means in the Ethereum world (function name, args,
return types and no bytecode and verification key). Given this I renamed
`FunctionAbiHeader` as `FunctionAbi` and what was `FunctionAbi` is now
`FunctionArtifact`.
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: renaming abi as artifact AztecProtocol/aztec-packages
2 participants
@benesjan @iAmMichaelConnor