refactor: renaming abi as artifact #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
force-pushed
the
janb/artifact-insted-of-abi
branch
from
df2f9a1
to
863ba94
Compare
benesjan
changed the title
spypsy
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Doesn't look like anything's changed here, still see ABI on the copy if that was the intention
There was a problem hiding this comment.
You are right. Updated the diagram in 3a56231
spypsy
reviewed
Oct 10, 2023
There was a problem hiding this comment.
Do we want to keep the directory as foundation/abi if all other references related to this are now called artifact?
There was a problem hiding this comment.
I would rename it but I think it makes sense to do it in a separate PR because moving files and renaming their contents can result in ugly conflicts.
spypsy
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2101
Note: In some places it made sense to use the ABI term because it really referred to what ABI means in the Ethereum world (function name, args, return types and no bytecode and verification key). Given this I renamed
FunctionAbiHeaderasFunctionAbiand what wasFunctionAbiis nowFunctionArtifact.Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.