Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aztecup command to manage versions easily #2870

Closed
rahul-kothari opened this issue Oct 16, 2023 · 1 comment · Fixed by #3128
Closed

aztecup command to manage versions easily #2870

rahul-kothari opened this issue Oct 16, 2023 · 1 comment · Fixed by #3128
Assignees
@alexghr

Comments

@rahul-kothari
Copy link
Contributor

rahul-kothari commented Oct 16, 2023 •
edited
Loading

  • Update local package.json for any @aztec specific npm packages
  • Update any nargo.toml to latest aztec-nr version
  • Error if not run within a project
  • Sandbox to error if aztec-nr version used is not the same version number as the sandbox

With @alexghr working on Noir Wasm (that will remove the need to update nargo), and dockerising aztec-cli with the sandbox (which will remove the need of separately updating the cli), we just need the tool to update all npm packages locally (incl @aztec/sandbox) with an option to update to a specific version!

Ideal UX

First-time installation:
Install sandbox (docker, node v18 etc)
Install aztec-cli

For updating

cd YOUR_REPO
aztecup
@rahul-kothari rahul-kothari added this to A3 Oct 16, 2023
@rahul-kothari rahul-kothari converted this from a draft issue Oct 16, 2023
@rahul-kothari rahul-kothari changed the title sandboxup command to manage versions easily aztecup command to manage versions easily Oct 16, 2023
@rahul-kothari rahul-kothari mentioned this issue Oct 16, 2023
Closed
@rahul-kothari rahul-kothari mentioned this issue Oct 23, 2023
Closed
@alexghr
Copy link
Contributor

alexghr commented Oct 23, 2023

I think we should check if the user is in a git repo and have the aztecup command refuse to run if their workspace is dirty (similar to how git rebase would refuse to run with uncomitted files)

@alexghr alexghr mentioned this issue Oct 23, 2023
Closed
@alexghr alexghr moved this from Todo to In Progress in A3 Oct 27, 2023
@alexghr alexghr mentioned this issue Nov 1, 2023
Merged
4 tasks
@alexghr alexghr moved this from In Progress to In Review in A3 Nov 1, 2023
alexghr added a commit that referenced this issue Nov 2, 2023
@alexghr
feat: add cli command update aztec dependencies (#3128)
0c05d8b 
This PR adds a new command to aztec-cli to update a contract's Aztec.nr
and `@aztec` dependencies.

LE: This command was refactored to `update` and now updates both
Nargo.toml _and_ package.json.

Fix #2870 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexghr alexghr

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add cli command update aztec dependencies AztecProtocol/aztec-packages
2 participants
@alexghr @rahul-kothari