Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure acvm.js properly handles errors #2896

Closed
ludamad opened this issue Oct 17, 2023 · 1 comment
Closed

ensure acvm.js properly handles errors #2896

ludamad opened this issue Oct 17, 2023 · 1 comment
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@ludamad
Copy link
Collaborator

ludamad commented Oct 17, 2023

e2e tests are being observed to run for multiple hours in some failure cases where lots of output is presented. A specific instance for reference can be found here.

The core problem is error handling in the acvm.js component, but this is a problem in general if we print continuous output.

Key Points:

  1. The e2e container doesn't seem to exit upon encountering an error in the test. The error seen might be getting swallowed instead of being propagated
  2. The continuous noise from Anvil in the output prevents the 10-minute kill switch from terminating the test.

Actions to do or break-out into new issues:

  • Ensure proper error propagation, especially concerning the wasm simulator error. Can change line 710 of acvm_js.js to throw an error and observe the behavior above, potentially running with --detectOpenHandles.

Done

  • Silence Anvil output.
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 17, 2023
@ludamad ludamad changed the title e2e test not exiting properly e2e test failures not exiting properly Oct 17, 2023
@ludamad ludamad added the A-devops Area: Devops. E.g. CI / build systems label Oct 17, 2023
@charlielye
Copy link
Contributor

charlielye commented Oct 17, 2023

Also, just a quick bit of envelope math, if all our e2e tests wait for the full 3hr timeout:
60m*3hr*20credits*34tests / 25000credits_per_pack * $15per_pack = $73 for a single run of the workflow.
Ouch.

ludamad pushed a commit that referenced this issue Oct 18, 2023
@ludamad ludamad changed the title e2e test failures not exiting properly ensure acvm.js properly handles errors Oct 23, 2023
@ludamad ludamad closed this as completed Aug 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
Archived in project
Development

No branches or pull requests

2 participants