-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AddressNote’s commitment hiding #2921
Comments
What was the note's original purpose? Did it need "hiding" for the example contract that it was originally written for? (I.e. was omitting randomness intentional, or accidental?) |
@iAmMichaelConnor I think it was accidental in this case because it's used in the escrow contract. But even if it was not accidental I think it should contain the randomness because we moved it to aztec.nr for general use. |
+ Fixes #2921 + minor ValueNote improvement
As @critesjosh pointed out we do not currently use randomness in AddressNote. We should do that to make the commitment hiding.
The text was updated successfully, but these errors were encountered: