Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AddressNote’s commitment hiding #2921

Closed
benesjan opened this issue Oct 18, 2023 · 2 comments · Fixed by #2965
Closed

Make AddressNote’s commitment hiding #2921

benesjan opened this issue Oct 18, 2023 · 2 comments · Fixed by #2965
Assignees

Comments

@benesjan
Copy link
Contributor

As @critesjosh pointed out we do not currently use randomness in AddressNote. We should do that to make the commitment hiding.

@iAmMichaelConnor
Copy link
Contributor

What was the note's original purpose? Did it need "hiding" for the example contract that it was originally written for? (I.e. was omitting randomness intentional, or accidental?)

@benesjan
Copy link
Contributor Author

What was the note's original purpose? Did it need "hiding" for the example contract that it was originally written for? (I.e. was omitting randomness intentional, or accidental?)

@iAmMichaelConnor I think it was accidental in this case because it's used in the escrow contract. But even if it was not accidental I think it should contain the randomness because we moved it to aztec.nr for general use.

benesjan added a commit that referenced this issue Oct 23, 2023
+ Fixes #2921
+ minor ValueNote improvement
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants