Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol: Base Rollup Circuit #3148

Closed
Tracked by #3109
iAmMichaelConnor opened this issue Oct 31, 2023 · 0 comments · Fixed by #3558
Closed
Tracked by #3109

Protocol: Base Rollup Circuit #3148

iAmMichaelConnor opened this issue Oct 31, 2023 · 0 comments · Fixed by #3558
Assignees
@LHerskind @rahul-kothari
Labels
A-documentation Area: relates to documentation A-protocol Area: relates to designing / explaining the protocol

Comments

@iAmMichaelConnor
Copy link
Contributor

iAmMichaelConnor commented Oct 31, 2023 •
edited
Loading

Explain / justify the requirements for this circuit.
Describe the Public Inputs ABI & the Bus ABI for this circuit.
Explain the statements (logic) and assertions, neatly organised.
Explain possible future refactoring / optimisation opportunities.
Will we allow for various 'sizes' of arrays in the ABI?
Explain limitations of the circuit.
Explain uncertainties (e.g. choice of constants).
@iAmMichaelConnor iAmMichaelConnor mentioned this issue Oct 31, 2023
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 31, 2023
@iAmMichaelConnor iAmMichaelConnor added A-documentation Area: relates to documentation A-protocol Area: relates to designing / explaining the protocol labels Oct 31, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📝 Protocol Description milestone Oct 31, 2023
@LHerskind LHerskind mentioned this issue Dec 4, 2023
Merged
4 tasks
@LHerskind LHerskind moved this from Todo to In Review in A3 Dec 11, 2023
LHerskind added a commit that referenced this issue Dec 18, 2023
@LHerskind @rahul-kothari
@benesjan @sklppy88
docs: Yellow paper rollup circuits and state update (#3558)
b2d6376 
PR looking to fix #3148, #3149 and #3150.

---------

Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
Co-authored-by: esau <152162806+sklppy88@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Dec 18, 2023
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@LHerskind @rahul-kothari
@benesjan @sklppy88
docs: Yellow paper rollup circuits and state update (AztecProtocol#3558)
4cbcab1 
PR looking to fix AztecProtocol#3148, AztecProtocol#3149 and AztecProtocol#3150.

---------

Co-authored-by: Rahul Kothari <rahul.kothari.201@gmail.com>
Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
Co-authored-by: esau <152162806+sklppy88@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

@rahul-kothari rahul-kothari

Labels
A-documentation Area: relates to documentation A-protocol Area: relates to designing / explaining the protocol
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Yellow paper rollup circuits and state update AztecProtocol/aztec-packages
3 participants
@LHerskind @rahul-kothari @iAmMichaelConnor