Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Args (de)serialisation fails for array of structs #3193

Closed
rahul-kothari opened this issue Nov 2, 2023 · 3 comments · Fixed by noir-lang/noir#3401 or #3197
Closed

Args (de)serialisation fails for array of structs #3193

rahul-kothari opened this issue Nov 2, 2023 · 3 comments · Fixed by noir-lang/noir#3401 or #3197
Assignees
Labels
C-aztec.nr Component: Aztec smart contract framework T-bug Type: Bug. Something is broken.

Comments

@rahul-kothari
Copy link
Contributor

rahul-kothari commented Nov 2, 2023

The following fails to compile.

Pointed out by @drgorillamd

Bug is in the aztec macros, which automagically calculate the args hash, so it tries to recognise the types of the parameters and injects automatically calls to an arguments hasher that involve casts, calls to serialise, etc

image
image

@rahul-kothari rahul-kothari added T-bug Type: Bug. Something is broken. C-aztec.nr Component: Aztec smart contract framework labels Nov 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 2, 2023
@simon-something
Copy link

Min repro example: https://github.com/drgorillamd/aztec-big-gist/blob/bug/args-array/src/main.nr

@Maddiaa0
Copy link
Member

Maddiaa0 commented Nov 2, 2023

Min repro example: https://github.com/drgorillamd/aztec-big-gist/blob/bug/args-array/src/main.nr

Thanks for including this!

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 2, 2023
@Maddiaa0 Maddiaa0 reopened this Nov 2, 2023
@Maddiaa0
Copy link
Member

Maddiaa0 commented Nov 2, 2023

@Maddiaa0 Maddiaa0 mentioned this issue Nov 2, 2023
4 tasks
Maddiaa0 added a commit that referenced this issue Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-aztec.nr Component: Aztec smart contract framework T-bug Type: Bug. Something is broken.
Projects
Archived in project
3 participants