Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noir-compiler should fail loudly if two different versions of the same library are detected #3201

Closed
alexghr opened this issue Nov 2, 2023 · 1 comment

Comments

@alexghr
Copy link
Contributor

alexghr commented Nov 2, 2023

When compiling code with @aztec/noir-compiler with the wasm backend it goes ahead and pulls dependencies recursively into a dependency tree. The names of these libraries are then held in a global namespace for the wasm backend to consume.

Because of the global nature of this namespace it can not not distinguish between different versions of the same library (e.g. the name aztec will point to the same library from anywhere in the dependency tree). It currently uses the first version it resolved every time.

We should change the compiler to crash loudly if different versions of the same library are detected at least until the wasm backend supports multiple versions of the same library.

Original discussion: #2737 (comment)

Other discussion here: noir-lang/noir#3213 (comment)

@alexghr alexghr added this to A3 Nov 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 2, 2023
@alexghr alexghr changed the title noir-compiler should fail loudly if incompatible versions of the same library are detected noir-compiler should fail loudly if two different versions of the same library are detected Nov 2, 2023
@alexghr
Copy link
Contributor Author

alexghr commented Jan 12, 2024

We migrated to aztec-nargo with 0.17.0 so this is not longer relevant.

@alexghr alexghr closed this as completed Jan 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant