feat: compile noir contracts with noir_wasm #2737

alexghr · 2023-10-09T07:49:20Z

This PR adds support for compiling contracts with noir_wasm instead of nargo.

Fix #2644

Requires:

chore: Add visibility modifiers #2728
fix: add pub modifier to grumpkin functions noir-lang/noir#3036
feat: publish aztec build of noir_wasm noir-lang/noir#3049
feat: return compilation errors from noir_wasm noir-lang/noir#3091
feat: noir-wasm takes dependency graph noir-lang/noir#3213
updates to noir-contracts to add pub modifiers to return types (TBD)
e.g. getThisAddress() -> pub Field here

aztec-packages/yarn-project/noir-contracts/src/contracts/test_contract/src/main.nr

Line 45 in 4881414

fn getThisAddress() -> Field {
build noir_wasm with aztec feature enabled (based on feat: publish aztec build of noir_wasm noir-lang/noir#3049)
output compilation errors (based on feat: return compilation errors from noir_wasm noir-lang/noir#3091)

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

socket-security · 2023-10-09T07:58:07Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@noir-lang/source-resolver	0.18.0-3919619.aztec	None	`+0`	7.88 kB	noir-lang
@noir-lang/noir_wasm	0.18.0-3919619.aztec	None	`+1`	15.6 MB	noir-lang
vite	4.4.8	eval, network, filesystem, shell, environment	`+0`	3.33 MB	vitebot
unzipit	1.4.3	network	`+1`	234 kB	greggman
idb-keyval	6.2.1	None	`+0`	53.8 kB	jaffathecake
libp2p	0.46.6	None	`+0`	1.61 MB	npm-service-account-libp2p
zod	3.22.4	None	`+0`	628 kB	colinmcd94

alexghr · 2023-10-10T09:17:54Z

Running the compiler on this branch is not going to work until a newer version of noir_wasm is published on npm

yarn-project/noir-compiler/src/compile/noir/noir-wasm-compiler.ts

PhilWindle · 2023-10-11T09:59:04Z

yarn-project/noir-compiler/src/cli/contract.ts

@@ -20,6 +25,7 @@ export function compileContract(program: Command, name = 'contract', log: LogFn
    .option('-o, --outdir <path>', 'Output folder for the binary artifacts, relative to the project path', 'target')
    .option('-ts, --typescript <path>', 'Optional output folder for generating typescript wrappers', undefined)
    .option('-i, --interface <path>', 'Optional output folder for generating an Aztec.nr contract interface', undefined)
+    .option('--compiler <compiler>', 'Compiler to use (nargo|wasm)', 'nargo')


If the default is nargo, does this mean the aztec-cli will use nargo? I can't see a change in the aztec-cli.

alexghr · 2023-10-26T07:49:30Z

I'm investigating why 4 end to end tests are currently failing with Failed to solve brillig function, reason: explicit trap hit in brillig.

alexghr · 2023-10-26T14:33:24Z

My last commit undid a bunch of changes:

wasm compiler is still available, only as --compiler wasm flag. It is not the default
Nargo compilation of noir-contracts was restored
noir-version.json was restored (for the above compilation step)
e2e error message expectation restored as before

I've done this because noir_wasm doesn't output debug information yet so it would make fixing issues in contracts difficult. The wasm compiler can still be used if needed (will be used in dockerized aztec-cli, see #3031).

Plan going forward:

get noir_wasm to output debug information output debug info when compiling with noir_wasm noir-lang/noir#3303
build noir-contracts with noir_wasm instead of nargo
make --compiler wasm the default option
keep --compiler nargo around for users that want/need it
use consistent nargo/noir_wasm version number so that we might switch between them easily (one uses build numbers e.g. aztec.1, aztec.2 and the other hashes e.g. aztec.abcdef)

spalladino

Awesome work! Left a bunch of comments.

yarn-project/foundation/.eslintrc.cjs

yarn-project/noir-compiler/src/cli/contract.ts

spalladino · 2023-10-26T17:07:10Z

yarn-project/noir-compiler/src/compile/noir/dependencies/dependency-manager.ts

+
+  async #recursivelyResolveDependencies(packageName: string, noirPackage: NoirPackage): Promise<void> {
+    for (const [name, config] of Object.entries(noirPackage.getDependencies())) {
+      // TODO what happens if more than one package has the same name but different versions?


I'd blow up loudly, rather than silently pick either of them. Though you'd probably need to use semver to collect all version restrictions and get their intersection.

Hm, I thought about it but noir libs don't have a version number in Nargo.toml and because of this is makes comparing git dependencies to relative-path dependencies difficult. (e.g. contract depends on aztec and authwit via git, authwit depends on aztec via relative path)

Should we then just use the git revision, and if we have a relative path, we "inherit" the git revision of the parent that included it? That should let us blow up if we see two different git revisions requested.

yarn-project/noir-compiler/src/compile/noir/dependencies/github-dependency-resolver.ts

spalladino · 2023-10-26T17:29:27Z

yarn-project/noir-compiler/src/compile/noir/package.ts

I understand that nargo has a concept of workspace (see here). Is this something we'd need to manually support from wasm as well?

Nargo does support workspaces but this wrapper around it didn't advertise that functionality. The wasm compiler doesn't support workspaces but we could do it in node.js but it would be pretty slow: we'd have to compile each contract serially because the wasm code uses a global function to resolve file contents (or worker threads? 👀)

Let's open a new issue to track "workspace support" then, given it's not a current feature that we lose because of the switch to wasm, but a new thing to implement.

yarn-project/noir-compiler/src/compile/noir/package.ts

yarn-project/noir-compiler/src/index.ts

yarn-project/noir-contracts/scripts/compile.sh

yarn-project/.yarn/patches/ts-jest-npm-29.1.1-04e888e48e.patch

…b-dependency-resolver.ts Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>

Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>

This PR dockerizes aztec-cli. It requires #2737 to be merged in first. Fix #2875 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ### Features * `FieldNote` ([#3037](#3037)) ([3d1ffd0](3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](#2569)) ([997c15c](997c15c)) * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Compile noir contracts with noir_wasm ([#2737](#2737)) ([524cecf](524cecf)) * Dockerize aztec-cli ([#3031](#3031)) ([ec2e3c2](ec2e3c2)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](#2740)) ([f800a36](f800a36)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](#3091)) ([906429f](906429f)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ([16abb5a](16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](#2673)) ([ccd4611](ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](#3097)) ([57bec53](57bec53)) * Broken `FieldNote` test ([#3135](#3135)) ([fe78ecf](fe78ecf)) * Docker-compose up, rather than run. ([#3081](#3081)) ([242f780](242f780)) * Formatting ([#3070](#3070)) ([e1633d3](e1633d3)) * Minor stale naming fix ([#3117](#3117)) ([a6786ae](a6786ae)) * Push cli docker image to docker hub ([#3120](#3120)) ([ccad50f](ccad50f)) * Remove duplicate terraform resource definition ([#3066](#3066)) ([d5abadb](d5abadb)) * Retry request spot ([#3116](#3116)) ([82de5f1](82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * E2e on spots [ci rebuild] ([#3068](#3068)) ([15db6bf](15db6bf)) * Fix dapp_testing e2e race condition ([#3094](#3094)) ([89e7c21](89e7c21)) * Remove docs mirror ([#3122](#3122)) ([3fa51e2](3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](#3134)) ([3e07104](3e07104)) ### Documentation * Initial keys spec ([#3035](#3035)) ([4b24c58](4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

In #2737 noir_wasm was added back for contract compilation but kept as a secondary option to Nargo because at the time noir_wasm did not output debug info. This PR switches the default to noir_wasm because it now supports everything we need for contract compilation # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ### Features * `FieldNote` ([#3037](AztecProtocol/aztec-packages#3037)) ([3d1ffd0](AztecProtocol/aztec-packages@3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](AztecProtocol/aztec-packages#2569)) ([997c15c](AztecProtocol/aztec-packages@997c15c)) * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Compile noir contracts with noir_wasm ([#2737](AztecProtocol/aztec-packages#2737)) ([524cecf](AztecProtocol/aztec-packages@524cecf)) * Dockerize aztec-cli ([#3031](AztecProtocol/aztec-packages#3031)) ([ec2e3c2](AztecProtocol/aztec-packages@ec2e3c2)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](AztecProtocol/aztec-packages#2740)) ([f800a36](AztecProtocol/aztec-packages@f800a36)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](AztecProtocol/aztec-packages#3091)) ([906429f](AztecProtocol/aztec-packages@906429f)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ([16abb5a](AztecProtocol/aztec-packages@16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](AztecProtocol/aztec-packages#2673)) ([ccd4611](AztecProtocol/aztec-packages@ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](AztecProtocol/aztec-packages#3097)) ([57bec53](AztecProtocol/aztec-packages@57bec53)) * Broken `FieldNote` test ([#3135](AztecProtocol/aztec-packages#3135)) ([fe78ecf](AztecProtocol/aztec-packages@fe78ecf)) * Docker-compose up, rather than run. ([#3081](AztecProtocol/aztec-packages#3081)) ([242f780](AztecProtocol/aztec-packages@242f780)) * Formatting ([#3070](AztecProtocol/aztec-packages#3070)) ([e1633d3](AztecProtocol/aztec-packages@e1633d3)) * Minor stale naming fix ([#3117](AztecProtocol/aztec-packages#3117)) ([a6786ae](AztecProtocol/aztec-packages@a6786ae)) * Push cli docker image to docker hub ([#3120](AztecProtocol/aztec-packages#3120)) ([ccad50f](AztecProtocol/aztec-packages@ccad50f)) * Remove duplicate terraform resource definition ([#3066](AztecProtocol/aztec-packages#3066)) ([d5abadb](AztecProtocol/aztec-packages@d5abadb)) * Retry request spot ([#3116](AztecProtocol/aztec-packages#3116)) ([82de5f1](AztecProtocol/aztec-packages@82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * E2e on spots [ci rebuild] ([#3068](AztecProtocol/aztec-packages#3068)) ([15db6bf](AztecProtocol/aztec-packages@15db6bf)) * Fix dapp_testing e2e race condition ([#3094](AztecProtocol/aztec-packages#3094)) ([89e7c21](AztecProtocol/aztec-packages@89e7c21)) * Remove docs mirror ([#3122](AztecProtocol/aztec-packages#3122)) ([3fa51e2](AztecProtocol/aztec-packages@3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](AztecProtocol/aztec-packages#3134)) ([3e07104](AztecProtocol/aztec-packages@3e07104)) ### Documentation * Initial keys spec ([#3035](AztecProtocol/aztec-packages#3035)) ([4b24c58](AztecProtocol/aztec-packages@4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

alexghr commented Oct 10, 2023

View reviewed changes

alexghr force-pushed the alexg/feat/noir-wasm branch from 87c8d75 to 31835f1 Compare October 10, 2023 10:14

PhilWindle requested changes Oct 11, 2023

View reviewed changes

alexghr force-pushed the alexg/feat/noir-wasm branch 2 times, most recently from 515ea33 to 80aff83 Compare October 17, 2023 10:27

alexghr force-pushed the alexg/feat/noir-wasm branch 3 times, most recently from d8a0e9e to ff3c8ed Compare October 25, 2023 10:26

alexghr mentioned this pull request Oct 25, 2023

feat: dockerize aztec-cli #3031

Merged

4 tasks

alexghr added 9 commits October 25, 2023 16:52

perf: avoid second yarn install

1035a8a

feat: add noir_wasm

6dcff34

refactor: remove nargo

9fe0024

refactor: alternative way to patch ts-jest

50176b6

fix: include yarn patches in yarn-project-base

ec6024c

fix: common package.json

007abef

ci: add noir-compiler-build to cci config

d9c2810

chore: update noir_wasm

6466bb3

refactor: remove noir-contracts-build image

6d0fba2

alexghr force-pushed the alexg/feat/noir-wasm branch from ff3c8ed to 6d0fba2 Compare October 25, 2023 15:52

alexghr and others added 5 commits October 25, 2023 17:11

fix: yarn-project docker image

45e243b

chore: purge noir-version.json

ad8df0e

Merge branch 'master' into alexg/feat/noir-wasm

1d481e5

chore: lint

d299290

chore: update acvm

71c1bf3

alexghr marked this pull request as ready for review October 26, 2023 07:47

alexghr added 2 commits October 26, 2023 11:59

fix: resolve project path before compiling

1b328b2

fix: throw an error if can't compile

82c01e2

alexghr added 2 commits October 26, 2023 16:10

chore: fix nargo snapshot tests in CI

f3fea51

fix: specify correct type for compiler flag

e43465b

spalladino reviewed Oct 26, 2023

View reviewed changes

alexghr and others added 13 commits October 27, 2023 08:29

Update yarn-project/noir-compiler/src/compile/noir/dependencies/githu…

89ea930

…b-dependency-resolver.ts Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>

Update yarn-project/noir-compiler/src/compile/noir/dependencies/githu…

eb8c172

…b-dependency-resolver.ts Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>

Update yarn-project/noir-compiler/src/compile/noir/noir-wasm-compiler.ts

bdbb0af

Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>

fix: address code review

8317f5f

fix: add zod to parse Nargo.toml

f8c7c7d

refactor: only look at src directory

fed8f58

fix: safely generate a filename from a git url

66283b4

fix: add comment to ts-jest patch

bf4244d

refactor: use memfs

62975d3

fix: write deps to tmp files and atomically move

54a002e

fix: code review

f957f14

fix: binary is latin1

f34ddf1

fix: tmp directory when extracting

334d51f

PhilWindle approved these changes Oct 27, 2023

View reviewed changes

alexghr added 2 commits October 27, 2023 14:49

Merge remote-tracking branch 'origin/master' into alexg/feat/noir-wasm

df88d72

chore: update package.json

85d15c4

alexghr merged commit 524cecf into master Oct 27, 2023
2 checks passed

alexghr deleted the alexg/feat/noir-wasm branch October 27, 2023 17:42

AztecBot mentioned this pull request Oct 27, 2023

chore(master): Release 0.13.0 #3067

Merged

This was referenced Nov 2, 2023

feat!: make noir_wasm the default compiler #3090

Merged

noir-compiler should fail loudly if two different versions of the same library are detected #3201

Closed

noir-compiler support for Nargo workspaces #3202

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: compile noir contracts with noir_wasm #2737

feat: compile noir contracts with noir_wasm #2737

alexghr commented Oct 9, 2023 •

edited

Loading

socket-security bot commented Oct 9, 2023 •

edited

Loading

alexghr commented Oct 10, 2023

PhilWindle Oct 11, 2023

alexghr commented Oct 26, 2023

alexghr commented Oct 26, 2023 •

edited

Loading

spalladino left a comment

spalladino Oct 26, 2023

alexghr Oct 27, 2023

spalladino Oct 27, 2023

spalladino Oct 26, 2023

alexghr Oct 27, 2023

spalladino Oct 27, 2023

feat: compile noir contracts with noir_wasm #2737

feat: compile noir contracts with noir_wasm #2737

Conversation

alexghr commented Oct 9, 2023 • edited Loading

Checklist:

socket-security bot commented Oct 9, 2023 • edited Loading

alexghr commented Oct 10, 2023

PhilWindle Oct 11, 2023

Choose a reason for hiding this comment

alexghr commented Oct 26, 2023

alexghr commented Oct 26, 2023 • edited Loading

spalladino left a comment

Choose a reason for hiding this comment

spalladino Oct 26, 2023

Choose a reason for hiding this comment

alexghr Oct 27, 2023

Choose a reason for hiding this comment

spalladino Oct 27, 2023

Choose a reason for hiding this comment

spalladino Oct 26, 2023

Choose a reason for hiding this comment

alexghr Oct 27, 2023

Choose a reason for hiding this comment

spalladino Oct 27, 2023

Choose a reason for hiding this comment

alexghr commented Oct 9, 2023 •

edited

Loading

socket-security bot commented Oct 9, 2023 •

edited

Loading

alexghr commented Oct 26, 2023 •

edited

Loading