feat(feature_branch): Private Kernel Circuit #2740

kevaundray · 2023-10-09T14:32:34Z

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
Every change is related to the PR description.
I have linked this pull request to relevant issues (if any exist).

socket-security · 2023-10-09T14:53:05Z

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@noir-lang/noir_js	0.16.0	None	`+4`	7.47 MB	noir-lang
@noir-lang/backend_barretenberg	0.7.10	network, filesystem	`+3`	17.7 MB	noir-lang
@noir-lang/noirc_abi	0.16.0	None	`+0`	827 kB	noir-lang
@noir-lang/acvm_js	0.30.0...0.28.0	None	`+0/-0`	5.88 MB	noir-lang

Re exporting globals doesn't quite work ): so I just replaced every use with constants gen and added a missing generator index

Abi to typescript is missing, so its a bit hard to get the inputs in the correct shape. For now, I've just zeroed out the witness map and passed it to executeCircuit. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).

This is some rough code to generate typescript bindings for a given abi.json # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: sirasistant <sirasistant@gmail.com>

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).

TomAFrench · 2023-10-10T19:39:41Z

yarn-project/noir-private-kernel/src/crates/private-kernel-lib/src/utils/uint256.nr

+        let high_0 = ((bytes[0] as u64) << 56)
+                | ((bytes[1] as u64) << 48)
+                | ((bytes[2] as u64) << 40)
+                | ((bytes[3] as u64) << 32)
+                | ((bytes[4] as u64) << 24)
+                | ((bytes[5] as u64) << 16)
+                | ((bytes[6] as u64) << 8)
+                |  (bytes[7] as u64);
+
+        let high_1 = ((bytes[8] as u64) << 56)
+                | ((bytes[9] as u64) << 48)
+                | ((bytes[10] as u64) << 40)
+                | ((bytes[11] as u64) << 32)
+                | ((bytes[12] as u64) << 24)
+                | ((bytes[13] as u64) << 16)
+                | ((bytes[14] as u64) << 8)
+                |  (bytes[15] as u64);
+
+        let low_0 = ((bytes[16] as u64) << 56)
+                | ((bytes[17] as u64) << 48)
+                | ((bytes[18] as u64) << 40)
+                | ((bytes[19] as u64) << 32)
+                | ((bytes[20] as u64) << 24)
+                | ((bytes[21] as u64) << 16)
+                | ((bytes[22] as u64) << 8)
+                |  (bytes[23] as u64);
+
+        let low_1 = ((bytes[24] as u64) << 56)
+                | ((bytes[25] as u64) << 48)
+                | ((bytes[26] as u64) << 40)
+                | ((bytes[27] as u64) << 32)
+                | ((bytes[28] as u64) << 24)
+                | ((bytes[29] as u64) << 16)
+                | ((bytes[30] as u64) << 8)
+                |  (bytes[31] as u64);


Note for later that we can reduce constraints by adding rather than ORing here.

…cuit init using the typescript generated types (#2763)

yarn-project/circuits.js/src/structs/index.ts

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>

Running `yarn noir:build && yarn test` on the noir-private-kernel-lib on this commit will give you a failure with the message ` Cannot satisfy constraint`. The problem is `function_tree_root_from_siblings` which calls `root_from_sibling_path` which fails on L32, the indexing of `indices[i]`. It is not an index out of bounds error, and seems to only happen with this test

To run the cpp tests, type the following into your shell: - cd ~/aztec-packages/circuits/cpp - cmake --preset default - cmake --build --preset default - ./build/bin/aztec3_utils_tests --gtest_filter=hash_tests.*

Co-authored-by: sirasistant <sirasistant@gmail.com>

)

sirasistant

The noir private kernel has been removed from the PXE so this PR only adds the code and some basic smoke tests to make sure that we don't make a breaking change

dan-aztec · 2023-10-31T00:03:51Z

yarn-project/noir-private-kernel/README.md

@@ -0,0 +1 @@
+# Noir Private Kernel


🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ### Features * `FieldNote` ([#3037](#3037)) ([3d1ffd0](3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](#2569)) ([997c15c](997c15c)) * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Compile noir contracts with noir_wasm ([#2737](#2737)) ([524cecf](524cecf)) * Dockerize aztec-cli ([#3031](#3031)) ([ec2e3c2](ec2e3c2)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](#2740)) ([f800a36](f800a36)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](#3091)) ([906429f](906429f)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](#3051)) ([16abb5a](16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](#2673)) ([ccd4611](ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](#3097)) ([57bec53](57bec53)) * Broken `FieldNote` test ([#3135](#3135)) ([fe78ecf](fe78ecf)) * Docker-compose up, rather than run. ([#3081](#3081)) ([242f780](242f780)) * Formatting ([#3070](#3070)) ([e1633d3](e1633d3)) * Minor stale naming fix ([#3117](#3117)) ([a6786ae](a6786ae)) * Push cli docker image to docker hub ([#3120](#3120)) ([ccad50f](ccad50f)) * Remove duplicate terraform resource definition ([#3066](#3066)) ([d5abadb](d5abadb)) * Retry request spot ([#3116](#3116)) ([82de5f1](82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * E2e on spots [ci rebuild] ([#3068](#3068)) ([15db6bf](15db6bf)) * Fix dapp_testing e2e race condition ([#3094](#3094)) ([89e7c21](89e7c21)) * Remove docs mirror ([#3122](#3122)) ([3fa51e2](3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](#3134)) ([3e07104](3e07104)) ### Documentation * Initial keys spec ([#3035](#3035)) ([4b24c58](4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](#2937)) ([db67aa1](db67aa1)) * Efficient ZM quotient computation ([#3016](#3016)) ([ebda5fc](ebda5fc)) * Measure plonk rounds ([#3065](#3065)) ([c8e1d8b](c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](#2780)) ([6c20b45](6c20b45)) * Pedersen in typescript. ([#3111](#3111)) ([933f1b2](933f1b2)) * Protogalaxy folding of challenges ([#2935](#2935)) ([7ed30e8](7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](#3006)) ([70b0f17](70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](#3075)) ([87fa621](87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](#3072)) ([2e289a5](2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](#3074)) ([52cf383](52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](#3115)) ([d294987](d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](#3079)) ([84f8db2](84f8db2)) * Remove unused pedersen c_binds ([#3058](#3058)) ([e71e5f9](e71e5f9)) * Removes pedersen commit native pairs method ([#3073](#3073)) ([69a34c7](69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@aztec-packages-v0.12.0...aztec-packages-v0.13.0) (2023-10-31) ### ⚠ BREAKING CHANGES * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ### Features * `FieldNote` ([#3037](AztecProtocol/aztec-packages#3037)) ([3d1ffd0](AztecProtocol/aztec-packages@3d1ffd0)) * Add Aztec Boxes page to docs ([#2569](AztecProtocol/aztec-packages#2569)) ([997c15c](AztecProtocol/aztec-packages@997c15c)) * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Compile noir contracts with noir_wasm ([#2737](AztecProtocol/aztec-packages#2737)) ([524cecf](AztecProtocol/aztec-packages@524cecf)) * Dockerize aztec-cli ([#3031](AztecProtocol/aztec-packages#3031)) ([ec2e3c2](AztecProtocol/aztec-packages@ec2e3c2)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * **feature_branch:** Private Kernel Circuit ([#2740](AztecProtocol/aztec-packages#2740)) ([f800a36](AztecProtocol/aztec-packages@f800a36)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * Migrate the init kernel CPP tests to noir ([#3091](AztecProtocol/aztec-packages#3091)) ([906429f](AztecProtocol/aztec-packages@906429f)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * PXE.getNotes(...) + refactor of note types ([#3051](AztecProtocol/aztec-packages#3051)) ([16abb5a](AztecProtocol/aztec-packages@16abb5a)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Bug Fixes * Bad contract txs publishing contract data ([#2673](AztecProtocol/aztec-packages#2673)) ([ccd4611](AztecProtocol/aztec-packages@ccd4611)) * Better error message for compute_note_hash_and_nullifier. ([#3097](AztecProtocol/aztec-packages#3097)) ([57bec53](AztecProtocol/aztec-packages@57bec53)) * Broken `FieldNote` test ([#3135](AztecProtocol/aztec-packages#3135)) ([fe78ecf](AztecProtocol/aztec-packages@fe78ecf)) * Docker-compose up, rather than run. ([#3081](AztecProtocol/aztec-packages#3081)) ([242f780](AztecProtocol/aztec-packages@242f780)) * Formatting ([#3070](AztecProtocol/aztec-packages#3070)) ([e1633d3](AztecProtocol/aztec-packages@e1633d3)) * Minor stale naming fix ([#3117](AztecProtocol/aztec-packages#3117)) ([a6786ae](AztecProtocol/aztec-packages@a6786ae)) * Push cli docker image to docker hub ([#3120](AztecProtocol/aztec-packages#3120)) ([ccad50f](AztecProtocol/aztec-packages@ccad50f)) * Remove duplicate terraform resource definition ([#3066](AztecProtocol/aztec-packages#3066)) ([d5abadb](AztecProtocol/aztec-packages@d5abadb)) * Retry request spot ([#3116](AztecProtocol/aztec-packages#3116)) ([82de5f1](AztecProtocol/aztec-packages@82de5f1)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * E2e on spots [ci rebuild] ([#3068](AztecProtocol/aztec-packages#3068)) ([15db6bf](AztecProtocol/aztec-packages@15db6bf)) * Fix dapp_testing e2e race condition ([#3094](AztecProtocol/aztec-packages#3094)) ([89e7c21](AztecProtocol/aztec-packages@89e7c21)) * Remove docs mirror ([#3122](AztecProtocol/aztec-packages#3122)) ([3fa51e2](AztecProtocol/aztec-packages@3fa51e2)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) * Rename private-kernel subpackage to protocol-circuits ([#3134](AztecProtocol/aztec-packages#3134)) ([3e07104](AztecProtocol/aztec-packages@3e07104)) ### Documentation * Initial keys spec ([#3035](AztecProtocol/aztec-packages#3035)) ([4b24c58](AztecProtocol/aztec-packages@4b24c58)) </details> <details><summary>barretenberg.js: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg.js-v0.12.0...barretenberg.js-v0.13.0) (2023-10-31) ### Features * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) ### Miscellaneous * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) </details> <details><summary>barretenberg: 0.13.0</summary> ## [0.13.0](AztecProtocol/aztec-packages@barretenberg-v0.12.0...barretenberg-v0.13.0) (2023-10-31) ### Features * Adding structure to Transcript ([#2937](AztecProtocol/aztec-packages#2937)) ([db67aa1](AztecProtocol/aztec-packages@db67aa1)) * Efficient ZM quotient computation ([#3016](AztecProtocol/aztec-packages#3016)) ([ebda5fc](AztecProtocol/aztec-packages@ebda5fc)) * Measure plonk rounds ([#3065](AztecProtocol/aztec-packages#3065)) ([c8e1d8b](AztecProtocol/aztec-packages@c8e1d8b)) * New script to output table of benchmarks for README pasting. ([#2780](AztecProtocol/aztec-packages#2780)) ([6c20b45](AztecProtocol/aztec-packages@6c20b45)) * Pedersen in typescript. ([#3111](AztecProtocol/aztec-packages#3111)) ([933f1b2](AztecProtocol/aztec-packages@933f1b2)) * Protogalaxy folding of challenges ([#2935](AztecProtocol/aztec-packages#2935)) ([7ed30e8](AztecProtocol/aztec-packages@7ed30e8)) * Zeromorph with concatenation (Goblin Translator part 10) ([#3006](AztecProtocol/aztec-packages#3006)) ([70b0f17](AztecProtocol/aztec-packages@70b0f17)) ### Miscellaneous * Add stdlib tests for pedersen commitment ([#3075](AztecProtocol/aztec-packages#3075)) ([87fa621](AztecProtocol/aztec-packages@87fa621)) * Automatic c_binds for commit should return a point instead of an Fr element ([#3072](AztecProtocol/aztec-packages#3072)) ([2e289a5](AztecProtocol/aztec-packages@2e289a5)) * Cleanup remaining mentions of `compress` with pedersen in cpp and ts ([#3074](AztecProtocol/aztec-packages#3074)) ([52cf383](AztecProtocol/aztec-packages@52cf383)) * Remove endomorphism coefficient from ecc_add_gate ([#3115](AztecProtocol/aztec-packages#3115)) ([d294987](AztecProtocol/aztec-packages@d294987)) * Remove unecessary calls to `pedersen__init` ([#3079](AztecProtocol/aztec-packages#3079)) ([84f8db2](AztecProtocol/aztec-packages@84f8db2)) * Remove unused pedersen c_binds ([#3058](AztecProtocol/aztec-packages#3058)) ([e71e5f9](AztecProtocol/aztec-packages@e71e5f9)) * Removes pedersen commit native pairs method ([#3073](AztecProtocol/aztec-packages#3073)) ([69a34c7](AztecProtocol/aztec-packages@69a34c7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

starting rewrite based off of #2740 literal cpp -> noir translation for first conversion --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com> Co-authored-by: Álvaro Rodríguez <sirasistant@gmail.com> Co-authored-by: Leila Wang <leizciw@gmail.com>

kevaundray added 3 commits October 9, 2023 14:30

add noir-private-kernel yarn member

1ec82f1

add initial private kernel circuit implementation

1faa513

move bugs/devex files out of noir project subfolder

380bd94

kevaundray changed the title ~~Feature Branch: Private Kernel Circuit~~ feat(feature_branch): Private Kernel Circuit Oct 9, 2023

sirasistant and others added 6 commits October 9, 2023 20:25

feat: Use constants_gen for constants (#2742)

6896db8

Re exporting globals doesn't quite work ): so I just replaced every use with constants gen and added a missing generator index

chore: Workspace integration for the noir private kernel (#2753)

64590fa

Savio-Sou mentioned this pull request Oct 10, 2023

Epic: Add Noir function solvers into TS noir-lang/noir#3079

Closed

TomAFrench reviewed Oct 10, 2023

View reviewed changes

kevaundray added 2 commits October 11, 2023 09:47

chore: Use Noir javascript packages to execute the private kernel cir…

de628ee

…cuit init using the typescript generated types (#2763)

chore: enable noir private kernel circuit init (#2781)

523d96a

kevaundray commented Oct 11, 2023

View reviewed changes

yarn-project/circuits.js/src/structs/index.ts Outdated Show resolved Hide resolved

sirasistant and others added 14 commits October 11, 2023 15:41

make init have valid inputs

9cb188d

add read_request_root_from_siblings wrapper method

14917f7

BUG BUG BUG SIMPLIFIED

554df95

WORKAROUND FOR BUG NOTED IN PREVIOUS COMMIT

4488ca1

update comment about reexporting tests

4f18be3

Add a from_u32 method for FunctionSelector

4c1b7b8

add interop tests

bcc2b5c

uncomment code as bug has been committed

4e4fe98

add l2_to_l1_hash interop tests

f0e2be6

To run the cpp tests, type the following into your shell: - cd ~/aztec-packages/circuits/cpp - cmake --preset default - cmake --build --preset default - ./build/bin/aztec3_utils_tests --gtest_filter=hash_tests.*

chore: Change private-kernel init to use BoundedVec (#2800)

362247b

Co-authored-by: sirasistant <sirasistant@gmail.com>

fix: mismatch in hashing for block hash

9235015

fix: comment out membership checks and fixed the remaining issues (#2915

d186c33

)

sirasistant added 7 commits October 25, 2023 10:43

test: fix block building test

ca7c408

test: bump bench timeout further

a3a8811

fix: use pedersen for addr nullifier (#3027)

28ec608

feat: uncomment read request membership check

e79724e

feat: fix contract membership check (#3034)

8ebdec5

Merge branch 'master' into feature_branch/private-kernel

845c6bd

refactor: removed functions for bit decomposition

b4aa42e

Savio-Sou mentioned this pull request Oct 25, 2023

Epic: Expose black box function solvers into TS noir-lang/noir#2811

Closed

sirasistant added 8 commits October 26, 2023 09:37

test: add smoke test for noir PKC

c15c8d6

Merge branch 'master' into feature_branch/private-kernel

cb245e7

restore cpp kernel circuits

a491ab6

chore: mock vks also in cpp

c6f3c9b

fix: revert vk hash changes

ef78ae0

refactor: cleaned up some todos and unused fns

6e029f1

chore: undo boxes changes

495bccc

Merge branch 'master' into feature_branch/private-kernel

cc3871f

sirasistant marked this pull request as ready for review October 26, 2023 13:07

sirasistant approved these changes Oct 26, 2023

View reviewed changes

sirasistant added 3 commits October 26, 2023 17:26

Merge branch 'master' into feature_branch/private-kernel

67f4fd4

style: fix formatting from master

81a2aac

Merge branch 'master' into feature_branch/private-kernel

b3aff3f

sirasistant merged commit f800a36 into master Oct 27, 2023
2 checks passed

sirasistant deleted the feature_branch/private-kernel branch October 27, 2023 08:02

AztecBot mentioned this pull request Oct 27, 2023

chore(master): Release 0.13.0 #3067

Merged

dan-aztec reviewed Oct 31, 2023

View reviewed changes

yarn-project/noir-private-kernel/README.md

@@ -0,0 +1 @@

# Noir Private Kernel

Copy link

Contributor

dan-aztec Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sir!!

Savio-Sou mentioned this pull request Oct 31, 2023

Epic: Profiler MVP noir-lang/noir#2941

Closed

dan-aztec mentioned this pull request Nov 2, 2023

feat: public kernel in noir #3186

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(feature_branch): Private Kernel Circuit #2740

feat(feature_branch): Private Kernel Circuit #2740

kevaundray commented Oct 9, 2023

socket-security bot commented Oct 9, 2023 •

edited

Loading

TomAFrench Oct 10, 2023

sirasistant left a comment

dan-aztec Oct 31, 2023

feat(feature_branch): Private Kernel Circuit #2740

feat(feature_branch): Private Kernel Circuit #2740

Conversation

kevaundray commented Oct 9, 2023

Checklist:

socket-security bot commented Oct 9, 2023 • edited Loading

TomAFrench Oct 10, 2023

Choose a reason for hiding this comment

sirasistant left a comment

Choose a reason for hiding this comment

dan-aztec Oct 31, 2023

Choose a reason for hiding this comment

socket-security bot commented Oct 9, 2023 •

edited

Loading