Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noir-protocol-circuits artifacts from repo and build on CI #3273

Closed
dan-aztec opened this issue Nov 8, 2023 · 0 comments · Fixed by #3816
Closed

Remove noir-protocol-circuits artifacts from repo and build on CI #3273

dan-aztec opened this issue Nov 8, 2023 · 0 comments · Fixed by #3816
Assignees
@dan-aztec

Comments

@dan-aztec
Copy link
Contributor

like we do for noir-contracts, we don't need to commit all artifacts, and can build on CI for use in things like tests.

(1) use noir_wasm compiler instead of nargo
(2) add scripts for compiling + run those scripts on CI for the monorepo docker image
@dan-aztec dan-aztec self-assigned this Nov 8, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 8, 2023
@dan-aztec dan-aztec mentioned this issue Nov 8, 2023
Merged
dan-aztec added a commit that referenced this issue Nov 22, 2023
@dan-aztec
feat: noir_wasm compilation of noir programs (#3272)
f9981d5 
Was starting #3273
and ran into an issue - the noir_wasm CLI is configured for compiling
azec.nr smart contracts only, so needs update to support `bin` package
type.
@dan-aztec dan-aztec linked a pull request Jan 4, 2024 that will close this issue
chore: build protocol circuits on CI and stop committing artifacts #3816
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dan-aztec dan-aztec

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: build protocol circuits on CI and stop committing artifacts AztecProtocol/aztec-packages
1 participant
@dan-aztec