Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MerkleTreeId accessible from Noir #3443

Closed
benesjan opened this issue Nov 28, 2023 · 0 comments · Fixed by #3809
Closed

Make MerkleTreeId accessible from Noir #3443

benesjan opened this issue Nov 28, 2023 · 0 comments · Fixed by #3809
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Nov 28, 2023 •
edited
Loading

Ensure that MerkleTreeId enum gets injected into constants_gen.nr.

Note: Look for TODO(#3443) when addressing this and use the newly generated values there.
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 28, 2023
@benesjan benesjan self-assigned this Nov 28, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Dec 13, 2023
@benesjan benesjan moved this from In Progress to Todo in A3 Dec 13, 2023
@benesjan benesjan mentioned this issue Jan 3, 2024
Merged
4 tasks
benesjan added a commit that referenced this issue Jan 3, 2024
@benesjan
feat: tree ids in noir (#3809)
ec2e36e 
Fixes
[#3443](#3443)

Given that the tree ids are used only in 1 noir file I decided to tackle
the issue just by adding a comment to merkle_tree_id.ts and grouping the
constants next to each other.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 3, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Jan 7, 2024
@benesjan @AztecBot
feat: tree ids in noir (#3809)
05c632b 
Fixes
[#3443](AztecProtocol/aztec-packages#3443)

Given that the tree ids are used only in 1 noir file I decided to tackle
the issue just by adding a comment to merkle_tree_id.ts and grouping the
constants next to each other.
Maddiaa0 pushed a commit that referenced this issue Jan 8, 2024
@benesjan @Maddiaa0
feat: tree ids in noir (#3809)
51bbf41 
Fixes
[#3443](#3443)

Given that the tree ids are used only in 1 noir file I decided to tackle
the issue just by adding a comment to merkle_tree_id.ts and grouping the
constants next to each other.
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@benesjan
feat: tree ids in noir (AztecProtocol#3809)
95261e5 
Fixes
[AztecProtocol#3443](AztecProtocol#3443)

Given that the tree ids are used only in 1 noir file I decided to tackle
the issue just by adding a comment to merkle_tree_id.ts and grouping the
constants next to each other.
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402
feat: tree ids in noir (#3809)
0d16b13 
Fixes
[#3443](AztecProtocol/aztec-packages#3443)

Given that the tree ids are used only in 1 noir file I decided to tackle
the issue just by adding a comment to merkle_tree_id.ts and grouping the
constants next to each other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: tree ids in noir AztecProtocol/aztec-packages
1 participant
@benesjan