Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make noir-circuits independent of aztec-nr #3589

Closed
Tracked by #3533
LHerskind opened this issue Dec 5, 2023 · 0 comments · Fixed by #3591
Closed
Tracked by #3533

Make noir-circuits independent of aztec-nr #3589

LHerskind opened this issue Dec 5, 2023 · 0 comments · Fixed by #3591
Assignees
@LHerskind

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Dec 5, 2023 •
edited
Loading

Constants that are used in the protocol circuits should not be imported from aztec-nr, but instead be directly in the protocol circuits. Then aztec-nr can import it from there as needed.
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 5, 2023
@LHerskind LHerskind mentioned this issue Dec 5, 2023
Closed
@LHerskind LHerskind self-assigned this Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Merged
benesjan pushed a commit that referenced this issue Dec 6, 2023
@LHerskind
refactor: Make noir-circuit independent of aztec-nr (#3591)
3013354 
Fixes #3589 by adding constants to `protocol-circuits` and removing them
from `aztec-nr`. The importing looks a bit clunky after since reexports
of modules did not seem to work in noir #3590.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Make noir-circuit independent of aztec-nr AztecProtocol/aztec-packages
1 participant
@LHerskind