Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxes CI tests no longer work #3705

Closed
spypsy opened this issue Dec 14, 2023 · 2 comments
Closed

Boxes CI tests no longer work #3705

spypsy opened this issue Dec 14, 2023 · 2 comments
Assignees

Comments

@spypsy
Copy link
Member

spypsy commented Dec 14, 2023

These were previously run by downloading the yarn-project and running a docker-compose with that image running the tests from yarn-project/boxes/....

Since boxes is no longer included in yarn-project directory this doesn't work anymore. In fact no Docker image is being built that includes the boxes currently.

@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 14, 2023
PhilWindle pushed a commit that referenced this issue Dec 15, 2023
- Fix syntax for checking if contracts were deployed
- Fix separator for `TO_TAINT` var list
- disable boxes in CI because of
#3705

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@charlielye
Copy link
Contributor

I'm giving this thought. Will propose best course of action soon.

AztecBot pushed a commit to AztecProtocol/build-system that referenced this issue Dec 16, 2023
- Fix syntax for checking if contracts were deployed
- Fix separator for `TO_TAINT` var list
- disable boxes in CI because of
AztecProtocol/aztec-packages#3705

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@charlielye
Copy link
Contributor

Resolving as part of: #3727

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Dec 22, 2023
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
- Fix syntax for checking if contracts were deployed
- Fix separator for `TO_TAINT` var list
- disable boxes in CI because of
AztecProtocol#3705

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants