Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow get_note to return notes that have been nullified. #3755

Closed
Tracked by #4128
critesjosh opened this issue Dec 20, 2023 · 2 comments · Fixed by #4238
Closed
Tracked by #4128

Allow get_note to return notes that have been nullified. #3755

critesjosh opened this issue Dec 20, 2023 · 2 comments · Fixed by #4238
Assignees
@nventuro
Labels
T-feedback Type: recording user feedback
Milestone
Execution Environ...

Comments

@critesjosh
Copy link
Contributor

Maybe return non-nullified notes by default and modify NoteGetterOptions to allow someone to specify that they want to get notes that have been nullified.

This came up when working on an airdrop contract with a feedback partner. They want to be able to prove the earliest interaction that someone had with a contract with a note. The proof of interaction is still valid for the airdrop, even if the corresponding note has been nullified.
@critesjosh critesjosh added the T-feedback Type: recording user feedback label Dec 20, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 20, 2023
@LHerskind LHerskind mentioned this issue Jan 18, 2024
Closed
@nventuro nventuro self-assigned this Jan 18, 2024
@LHerskind LHerskind added this to the Execution Environment milestone Jan 22, 2024
@LHerskind
Copy link
Contributor

As part of this work, it would be useful to refactor the test functions in the inclusion_proof_contract.

@LHerskind
Copy link
Contributor

Shortterm, can add a todo for the nullifier inclusion proofs etc, as #4179 should make it significantly easier to check those when the headers are included properly.

This was referenced Jan 25, 2024
Closed
Merged
@rahul-kothari rahul-kothari mentioned this issue Jan 29, 2024
Open
@LHerskind LHerskind moved this from Todo to In Progress in A3 Jan 29, 2024
nventuro added a commit that referenced this issue Jan 30, 2024
@nventuro
feat: nullified note retrieval in get_notes and view_notes (#4238)
8d02eb7 
Supercedes #4208,
which was closed as that one was created from a fork and we therefore
cannot run CI there.

Fixes #3755.
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Jan 30, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Jan 31, 2024
@nventuro @AztecBot
feat: nullified note retrieval in get_notes and view_notes (#4238)
1eaf52f 
Supercedes AztecProtocol/aztec-packages#4208,
which was closed as that one was created from a fork and we therefore
cannot run CI there.

Fixes AztecProtocol/aztec-packages#3755.
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@nventuro
feat: nullified note retrieval in get_notes and view_notes (AztecProt…
555eca4 
…ocol#4238)

Supercedes AztecProtocol#4208,
which was closed as that one was created from a fork and we therefore
cannot run CI there.

Fixes AztecProtocol#3755.
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402
feat: nullified note retrieval in get_notes and view_notes (#4238)
8b4a7a9 
Supercedes AztecProtocol/aztec-packages#4208,
which was closed as that one was created from a fork and we therefore
cannot run CI there.

Fixes AztecProtocol/aztec-packages#3755.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nventuro nventuro

Labels
T-feedback Type: recording user feedback
Projects
A3
Archived in project
Milestone
Execution Environment pre offsite
3 participants
@nventuro @LHerskind @critesjosh