Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecdsa_secp256r1 unsupported in Aztec.nr #3822

Closed
catmcgee opened this issue Jan 4, 2024 · 0 comments · Fixed by noir-lang/noir#3943
Closed

ecdsa_secp256r1 unsupported in Aztec.nr #3822

catmcgee opened this issue Jan 4, 2024 · 0 comments · Fixed by noir-lang/noir#3943
Assignees
@sirasistant

Comments

@catmcgee
Copy link
Contributor

catmcgee commented Jan 4, 2024 •
edited
Loading

ecdsa_secp256r1 has not been properly implemented in brillig

This fails - https://github.com/catmcgee/aztecnr-ecdsa-secp256r1/blob/main/src/main.nr - with panicked at 'not implemented: ICE: Black box function EcdsaSecp256r1 is not implemented', compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_black_box.rs:163:14

Reproduce

Clone and compile this https://github.com/catmcgee/aztecnr-ecdsa-secp256r1
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 4, 2024
@TomAFrench TomAFrench mentioned this issue Jan 4, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this issue Jan 4, 2024
@TomAFrench
fix: implement missing codegen for BlackBoxFunc::EcdsaSecp256r1 in …
2c5eceb 
…brillig (#3943)

# Description

## Problem\*

Resolves AztecProtocol/aztec-packages#3822

## Summary\*

This PR adds codegen for the `BlackBoxFunc::EcdsaSecp256r1` in brillig
and removes the catch-all branch when codegening black box functions.

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement missing codegen for BlackBoxFunc::EcdsaSecp256r1 in brillig noir-lang/noir
2 participants
@sirasistant @catmcgee