Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable public inputs hash and body hash (originally calldata hash) checks #4031

Closed
Tracked by #3533
, #4492
...
benesjan opened this issue Jan 16, 2024 · 2 comments
Closed
Tracked by #3533
, #4492
...

Re-enable public inputs hash and body hash (originally calldata hash) checks #4031

benesjan opened this issue Jan 16, 2024 · 2 comments
Assignees
@benesjan
Milestone
Execution Environ...

Comments

@benesjan
Copy link
Contributor

benesjan commented Jan 16, 2024 •
edited
Loading

Look for TODO(#4031) in codebase.
@benesjan benesjan mentioned this issue Jan 16, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 16, 2024
@LHerskind LHerskind added this to the Execution Environment milestone Jan 22, 2024
@LHerskind
Copy link
Contributor

Before renabling these checks we should be altering how they are computed as part of #3938

@LHerskind LHerskind mentioned this issue Feb 7, 2024
Closed
@benesjan benesjan moved this from Todo to Blocked in A3 Feb 8, 2024
@LHerskind
Copy link
Contributor

This is just an optimization that we are not using while there are no proofs anyway.

@LHerskind LHerskind closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in A3 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
Execution Environment pre offsite
Development

No branches or pull requests
2 participants
@benesjan @LHerskind