Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-vm(ts): Implement Bitwise operations #4120

Closed
9 tasks done
Tracked by #3383
Maddiaa0 opened this issue Jan 18, 2024 · 0 comments
Closed
9 tasks done
Tracked by #3383

public-vm(ts): Implement Bitwise operations #4120

Maddiaa0 opened this issue Jan 18, 2024 · 0 comments
Assignees
@fcarreiro
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Jan 18, 2024 •
edited by fcarreiro
Loading

Overview

Part of general implementation (and testing) of all of the VM instructions.

Tasks
Preview Give feedback
@Maddiaa0 Maddiaa0 mentioned this issue Jan 18, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 18, 2024
@Maddiaa0 Maddiaa0 added the C-avm Component: AVM related tickets (aka public VM) label Jan 18, 2024
@fcarreiro fcarreiro mentioned this issue Jan 23, 2024
Merged
Maddiaa0 pushed a commit that referenced this issue Jan 23, 2024
@fcarreiro
feat(avm): add tests for memory and bitwise instructions (#4184)
6dac650 
I have to implement memory tagging first for these to make sense, so I'm
merging this and then going back to it.

Advances #4120 and #4121.
@fcarreiro fcarreiro mentioned this issue Jan 26, 2024
Merged
fcarreiro added a commit that referenced this issue Jan 29, 2024
@fcarreiro
feat(avm): implement comparator opcodes (#4232)
973ff2f 
- Added `lt` and `equals` to AVM's memory types
- Implemented `eq`, `lt`, `lte` opcodes to work with integral types, fields, and inTag checking
- Added tests

Refers to #4120.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 30, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@fcarreiro
feat(avm): add tests for memory and bitwise instructions (AztecProtoc…
3c777a6 
…ol#4184)

I have to implement memory tagging first for these to make sense, so I'm
merging this and then going back to it.

Advances AztecProtocol#4120 and AztecProtocol#4121.
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@fcarreiro
feat(avm): implement comparator opcodes (AztecProtocol#4232)
6339c75 
- Added `lt` and `equals` to AVM's memory types
- Implemented `eq`, `lt`, `lte` opcodes to work with integral types, fields, and inTag checking
- Added tests

Refers to AztecProtocol#4120.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcarreiro fcarreiro

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fcarreiro @Maddiaa0