Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVM stack size is preventing compilation of brillig functions in the Noir test suite #4513

Closed
TomAFrench opened this issue Feb 8, 2024 · 1 comment · Fixed by noir-lang/noir#4316
Closed

AVM stack size is preventing compilation of brillig functions in the Noir test suite #4513

TomAFrench opened this issue Feb 8, 2024 · 1 comment · Fixed by noir-lang/noir#4316
Assignees
@sirasistant

Comments

@TomAFrench
Copy link
Member

The AVM is enforcing a maximum stack size which is preventing us from breaking regular brillig functions for which this restriction doesn't exist.

See test failures in noir-lang/noir#4216

cc @sirasistant
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 8, 2024
@sirasistant sirasistant self-assigned this Feb 9, 2024
@sirasistant
Copy link
Collaborator

After investigating the two failures:

  • The first failure (bigint) seems to be caused by the incorrect signature of bigint operations in brillig_gen. It'd fail anyway because bigint operations are not implemented in the brillig_vm.
  • The second failure seems to be related with the instrumentation the debugger is injecting, I'm trying to track down the root cause

@sirasistant sirasistant mentioned this issue Feb 9, 2024
Merged
5 tasks
github-merge-queue bot pushed a commit to noir-lang/noir that referenced this issue Feb 9, 2024
@sirasistant
fix: Ensure that destination register is allocated when moving betwee…
ca0a56e 
…n registers in brillig gen (#4316)

# Description

## Problem\*

Resolves AztecProtocol/aztec-packages#4513

## Summary\*

Move registers to registers wasn't ensuring that the destinations were
allocated so it was possible to codegen a case where move registers to
registers was squashing values

## Additional Context



## Documentation\*

Check one:
- [x] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@sirasistant @TomAFrench