Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Inbox): build parity circuits and put down plumbing to construct the block #4633

Closed
Tracked by #4492
LHerskind opened this issue Feb 16, 2024 · 0 comments · Fixed by #5082
Closed
Tracked by #4492

feat(Inbox): build parity circuits and put down plumbing to construct the block #4633

LHerskind opened this issue Feb 16, 2024 · 0 comments · Fixed by #5082
Assignees
@benesjan

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Feb 16, 2024 •
edited
Loading

Build the parity circuits as described in the yellow paper such that we can get the message values into the rollup state.
@LHerskind LHerskind mentioned this issue Feb 16, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 16, 2024
@LHerskind LHerskind changed the title feat: build in_hash circuits and put down plumbing to construct the block feat(inbox): build in_hash circuits and put down plumbing to construct the block Mar 8, 2024
@LHerskind LHerskind changed the title feat(inbox): build in_hash circuits and put down plumbing to construct the block feat(Inbox): build in_hash circuits and put down plumbing to construct the block Mar 8, 2024
@LHerskind LHerskind mentioned this issue Mar 8, 2024
Closed
@LHerskind LHerskind changed the title feat(Inbox): build in_hash circuits and put down plumbing to construct the block feat(Inbox): build parity circuits and put down plumbing to construct the block Mar 8, 2024
@benesjan benesjan mentioned this issue Mar 8, 2024
Merged
benesjan added a commit that referenced this issue Mar 13, 2024
@benesjan @sklppy88
feat: parity circuits (#5082)
335c46e 
Fixes #4633

Note: The new model currently can't be used to consume the message on L2
because old model root is being inserted to the messages tree in root
rollup circuit. We can be sure the root computed by new model is correct
because it is already being set in the header and checked in the Rollup
contract. I will start inserting the new root in my next PR in which
I'll purge the old inbox.

---------

Co-authored-by: esau <152162806+sklppy88@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: parity circuits AztecProtocol/aztec-packages
2 participants
@benesjan @LHerskind