Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: purge SafeU120 now that U128 is supported #4818

Closed
LHerskind opened this issue Feb 28, 2024 · 0 comments · Fixed by #4819
Closed

refactor: purge SafeU120 now that U128 is supported #4818

LHerskind opened this issue Feb 28, 2024 · 0 comments · Fixed by #4819
Assignees
@LHerskind

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Feb 28, 2024 •
edited
Loading

As noir now supports "safe" math natively and have a U128 implementation, we should use that instead of the SafeU120.

Replace the uses of SafeU120 with U128 and delete the library.
@LHerskind LHerskind added this to A3 Feb 28, 2024
@LHerskind LHerskind self-assigned this Feb 28, 2024
@LHerskind LHerskind converted this from a draft issue Feb 28, 2024
@LHerskind LHerskind mentioned this issue Feb 28, 2024
Merged
@LHerskind LHerskind moved this from Todo to In Progress in A3 Feb 28, 2024
@LHerskind LHerskind moved this from In Progress to Blocked in A3 Feb 28, 2024
LHerskind added a commit that referenced this issue Mar 1, 2024
@LHerskind
chore: purge SafeU120 (#4819)
9633b0f 
Fixes #4818.
@github-project-automation github-project-automation bot moved this from Blocked to Done in A3 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: purge SafeU120 AztecProtocol/aztec-packages
1 participant
@LHerskind