Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AuthWit): API for signing structured message #5075

Closed
Tracked by #2199
LHerskind opened this issue Mar 8, 2024 · 0 comments · Fixed by #5132
Closed
Tracked by #2199

feat(AuthWit): API for signing structured message #5075

LHerskind opened this issue Mar 8, 2024 · 0 comments · Fixed by #5132
Assignees
@LHerskind

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Mar 8, 2024 •
edited
Loading

The createAuthWitness is currently taking in a raw buffer or Field. This makes it hard to know what is actually being signed.

Make a createRawAuthWitness that is using the single buffer or field
Make a createAuthWitness that takes a request and caller, such that a frontend can provide this to the user, and the signing is done using those values for better visibility.
@LHerskind LHerskind mentioned this issue Mar 8, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Mar 8, 2024
@LHerskind LHerskind changed the title feat(AuthWit): Request to sign structured message feat(AuthWit): API for signing structured message Mar 8, 2024
@LHerskind LHerskind mentioned this issue Mar 8, 2024
Open
@LHerskind LHerskind added this to the Developer Facing Aztec.nr milestone Mar 8, 2024
@LHerskind LHerskind self-assigned this Mar 11, 2024
@LHerskind LHerskind mentioned this issue Mar 11, 2024
Merged
@LHerskind LHerskind linked a pull request Mar 11, 2024 that will close this issue
feat(AuthWit): simplify create authwit syntax #5132
Merged
LHerskind added a commit that referenced this issue Mar 18, 2024
@LHerskind
feat(AuthWit): simplify create authwit syntax (#5132)
d0a5b19 
Fixes #4821 and #5075. 

Renames the functions related to `AuthWit` to use a similar naming scheme.

Extends the `createAuthWit`, `setPublicAuthWit` and `cancelAuthWit` functions such that they can now take an object 
```typescript
{
  caller: AztecAddress;
  action: ContractFunctionInteraction | FunctionCall;
},
```

Allowing for adding a new authwit more simply.

Example:
```typescript
await user1Wallet.createAuthWit({
  caller: l2Bridge.address,
  action: l2Token.methods.burn(ownerAddress, withdrawAmount, nonce)
});
```
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(AuthWit): simplify create authwit syntax AztecProtocol/aztec-packages
1 participant
@LHerskind