Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for reading of SharedMutable from a different contract from private functions #5689

Closed
Tracked by #5606
benesjan opened this issue Apr 11, 2024 · 0 comments · Fixed by #5723
Closed
Tracked by #5606

Allow for reading of SharedMutable from a different contract from private functions #5689

benesjan opened this issue Apr 11, 2024 · 0 comments · Fixed by #5723
Assignees
@sklppy88

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 11, 2024 •
edited
Loading

In this issue we have the need to read SharedMutable of a different contract. The goal of this task is to implement that functionality.

In private this should be straightforward because the current implementation of historical access doesn't care whose contract you read storage of.

In public we will most likely need to generalize the current storageRead oracle or implement a new one because the current impl assumes that you are reading storage of the contract whose code is currently being executed.

Update: We will not need reading SharedMutable from public for the keys stuff so this task can focus on the private part only.
@benesjan benesjan mentioned this issue Apr 11, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 11, 2024
@benesjan benesjan mentioned this issue Apr 11, 2024
Closed
@benesjan benesjan changed the title Allow for reading of SharedMutable of a different contract Allow for reading of SharedMutable from a different contract Apr 11, 2024
@sklppy88 sklppy88 self-assigned this Apr 12, 2024
@benesjan benesjan changed the title Allow for reading of SharedMutable from a different contract Allow for reading of SharedMutable from a different contract from private functions Apr 12, 2024
@sklppy88 sklppy88 mentioned this issue Apr 15, 2024
Merged
sklppy88 added a commit that referenced this issue Apr 15, 2024
@sklppy88
feat: add shared mutable access from external contract #5689 (#5758)
cbda439 
Resolves #5689
@sklppy88 sklppy88 mentioned this issue Apr 15, 2024
Merged
@sklppy88 sklppy88 linked a pull request Apr 16, 2024 that will close this issue
feat: implement canonical key registry 5609 and implement shared mutable getter from another contract 5689 #5723
Merged
@sklppy88 sklppy88 moved this from Todo to In Progress in A3 Apr 16, 2024
@sklppy88 sklppy88 moved this from In Progress to In Review in A3 Apr 17, 2024
sklppy88 added a commit that referenced this issue Apr 17, 2024
@sklppy88 @benesjan
feat: implement canonical key registry 5609 and implement shared muta…
15b569f 
…ble getter from another contract 5689 (#5723)

Resolves #5609 and #5689

---------

Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@benesjan @sklppy88