Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually store outgoing notes #6867

Closed
Tracked by #5606
benesjan opened this issue Jun 4, 2024 · 0 comments · Fixed by #7022
Closed
Tracked by #5606

Actually store outgoing notes #6867

benesjan opened this issue Jun 4, 2024 · 0 comments · Fixed by #7022

Comments

@benesjan
Copy link
Contributor

benesjan commented Jun 4, 2024

In this PR I've implemented all the plumbing necessary to process the outgoing notes. The missing piece there is actually storing the note in the PXE db. I didn't do this because we are currently unable to recover note hash index for the outgoing because for that we would need a compute_note_hash function (the compute_note_hash_and_nullifier(...) function reverts when we can't get a hold of nullifier keys).

Look for "TODO(#6867)" in the codebase to find where the missing functionality should be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant