Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit chain id in the app circuit public inputs and validate in the kernel circuit #705

Closed
spalladino opened this issue May 29, 2023 · 1 comment

Comments

@spalladino
Copy link
Collaborator

spalladino commented May 29, 2023

To prevent the same proof from being submitted to more than one chain, we should include the chain id in the app circuit public inputs. So, when the user creates a ZKP for their tx, they just include the intended chain id as part of the public inputs. This value should then be validated by the kernel circuit.

TBD: Is it enough that the kernel circuit validates it? And we have a different kernel circuit for each chain, with the chain id hardcoded?

Raised by @LeilaWang in #656 (comment).

@github-project-automation github-project-automation bot moved this to Todo in A3 May 29, 2023
@spalladino spalladino added S-needs-discussion Status: Still needs more discussion before work can start. and removed S-needs-discussion Status: Still needs more discussion before work can start. labels Jun 5, 2023
@iAmMichaelConnor
Copy link
Contributor

I believe this is complete.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants